Generated (used) service names are inconsistent with configured or generated values
In gitaly the unicorn service is used and wired into it's config map. If I renamed the unicorn service to something like 'gitlab-unicorn' (not weird if using gitlab as a sub-chart) this will not be reflected in the gitaly and gitlab-shell configs.
# config.yaml.overrides
gitlab:
unicorn:
nameOverride: 'gitlab-unicorn'
helm template . --name Name -f config.yaml.overrides
The generated unicorn service name here is Name-gitlab-unicorn
, but the one used in e.g. gitaly will be Name-unicorn
This happened at at least the following places:
- registry service configuration in gitlab/unicorn configmap (configure the chart to use an external registry, it will still use 'Name-registry' in the configmap)
- unicorn service configuration in gitlab/gitaly configmap
- unicorn service configuration in gitlab/gitlab-shell configmap
These I found when configuring [unicorn, sidekiq, gitlab-shell, gitaly, migrations]