use rediss instead of tcp for workhorse sentinelList
Summary
We have deployed Redis with Redis Sentinel and want to connect Gitlab with this Redis Instance.
We are using TLS for the redis connection but in the configuration for workhorse i can see
Sentinel = [ "tcp://redis-node-0.redis-headless.redis.svc.cluster.local:26379","tcp://redis-node-1.redis-headless.redis.svc.cluster.local:26379","tcp://redis-node-2.redis-headless.redis.svc.cluster.local:26379" ]
Steps to reproduce
Deploy a redis cluster with sentinels using TLS and try to connect with Gitlab. You should see some error messages in the workhorse logs
Configuration used
(Please provide a sanitized version of the configuration used wrapped in a code block (```yaml))
values:
global:
redis:
auth:
enabled: true
secret: redis-gitlab-db-secret
key: password
host: mymaster
scheme: rediss
port: 6379
sentinels:
- host: redis-node-0.redis-headless.redis.svc.cluster.local
port: 26379
- host: redis-node-1.redis-headless.redis.svc.cluster.local
port: 26379
- host: redis-node-2.redis-headless.redis.svc.cluster.local
port: 26379
redis:
install: false
tls:
enabled: true
authClients: false
Current behavior
Workhorse is not using a TLS Connection
Expected behavior
Workhorse config should be
Sentinel = [ "rediss://redis-node-0.redis-headless.redis.svc.cluster.local:26379","rediss://redis-node-1.redis-headless.redis.svc.cluster.local:26379","rediss://redis-node-2.redis-headless.redis.svc.cluster.local:26379" ]
Versions
- Chart: 8.0.1
- Platform:
- Cloud: EKS
- Self-hosted:
- Kubernetes: (
kubectl version
)- Client: v1.28.2
- Server: v1.27.13
- Helm: (
helm version
)- Client:
- Server:
Relevant logs
Error accepting a client connection: error:0A00010B:SSL routines::wrong version number (addr=XXX.XX.XX.59:44214 laddr=XXX.XX.XX.19:26379)