GitLab Shell: add testing for extended configuration of sshd_config
The following discussion from !3581 (merged) should be addressed:
-
@WarheadsSE started a discussion: (+1 comment) No existing tests have failed
👍 regarding non-cluster related specs.Possible todos (now) or improvements in later MRs:
- Specific RSpec tests for the various forms. Especially
supplemental_config
- Emit a warning, when using these possibly dangerous features (user must provide valid config, or
sshd
will crash) - Make certificate usage possible to be directly implemented with the configuration alone, rather than extensions
- Specific RSpec tests for the various forms. Especially
Summary
We have added the functionality needed, and verified said functionality did not interrupt any existing tests. We should now add new tests to ensure this functionality, and that future changes do no accidentally impact them.
Acceptance
-
Specific RSpec added for supplemental_config
-
Emit warning when in use, reminding users of chart that they are responsible for the accuracy of the configuration. -
A link to the new examples under examples/
is added in the docs -
Docs team reviews the addition to the docs
Edited by Mitchell Nielsen