RuboCop updates in follow-up from "Update gitlab-styles from 6.2.0 to 9.0.0"
The following discussion from !2769 (merged) should be addressed:
# TODO: temporarily excluding the file with lints at RuboCop 1.36
Lint/BinaryOperatorWithIdenticalOperands:
Exclude:
- spec/configuration/gitaly_spec.rb
-
@WarheadsSE started a discussion: 🤔 That's vague. What line was this?
# TODO: temporarily excluding the file with lints at RuboCop 1.36
Fips/MD5:
Exclude:
- spec/features/backups_spec.rb
-
@WarheadsSE started a discussion: These changes:
diff --git a/spec/features/backups_spec.rb b/spec/features/backups_spec.rb
index c7f8c1d03..0e0e9f71a 100644
--- a/spec/features/backups_spec.rb
+++ b/spec/features/backups_spec.rb
@@ -155,7 +155,7 @@ describe "Restoring a backup" do
test_content = test_content.slice(test_content.index("PACK\u0000")..-1)
end
- expect(Digest::MD5.hexdigest(original_content)).to eq(Digest::MD5.hexdigest(test_content)),
+ expect(Digest::SHA2.hexdigest(original_content)).to eq(Digest::SHA2.hexdigest(test_content)),
"Expected #{file} to equal #{test_counterpart}"
end
end
Edited by Takuya Noguchi