gitlab-pages subchart: resources values from top-level values not passing through
Summary
In short, when passing through custom resource requests to the gitlab-pages subchart while rendering the top-level gitlab Chart (--set gitlab-pages.resources.requests.cpu=100m), the default resource requests get rendered instead of the passed ones.
Steps to reproduce
$ helm repo add gitlab https://charts.gitlab.io/
$ helm repo update
$ helm template \
gitlab/gitlab \
--set certmanager.install=false \
--set global.ingress.configureCertmanager=false \
--set global.pages.enabled=true \
--set gitlab-pages.resources.requests.cpu=100m \
| yq eval '''
select(
.kind=="Deployment"
and .metadata.name="gitlab-pages"
and .metadata.labels.chart | test("gitlab-pages.*")
).spec.template.spec.containers[]
| select(.name="gitlab-pages").resources
'''
requests:
cpu: 900m
memory: 2G
Configuration used
(Please provide a sanitized version of the configuration used wrapped in a code block (```yaml))
(Paste sanitized configuration here)
Unsure what to put here, happy to update if needed.
Current behavior
Getting default settings from Chart-local default values file.
Expected behavior
Get passed resource request settings from top-level chart render run.
Versions
- Chart: gitlab-pages 5.10.2
- Platform:
- Self-hosted: kind
- Kubernetes: (
kubectl version)- Client: 1.24.0
- Server: 1.24.0
- Helm: (
helm version)- Client: 3.8.2
- Server: N/A
Relevant logs
(Please provide any relevate log snippets you have collected, using code blocks (```) to format)
N/A