Skip to content

Ability to not set an ingress class

Summary

I would like to be able to prevent the chart from setting the ingress.class and ingress.provider annotations on my ingress objects. They only work, when I manually remove them after each update, as I only have one ingress provider for everything and don't use ingress.class or ingress.provider.

Steps to reproduce

  1. Install a standard RKE2 Rancher Cluster, with their nginx ingress
  2. Install this chart.

Configuration used

ingress:
    annotations:
      kubernetes.io/tls-acme: 'true'
    apiVersion: null
    configureCertmanager: false
    enabled: true
    path: /
    pathType: Prefix
    provider: ''
    tls: {}
    class: ''

Current behavior

https://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/charts/gitlab/charts/webservice/templates/ingress.yaml#L29-30

ingress.provider and ingress.class cannot be disabled on the ingress objects

Expected behavior

If I set both to empty or whatever else would make sense, they won't be added to the ingress object

Versions

  • Chart: 5.5.1
  • Platform:
    • Self-hosted: RKE2
  • Kubernetes: 1.21
  • Helm: Some version of Helm 3 shipped with Rancher. You don't access it as the user
Edited by Mitchell Nielsen