upgrade check fails on first install

Summary

upgrade check fails on first install (empty namespace) with the following error:

            It seems you are attempting an unsupported upgrade path. Please
            follow the upgrade documentation at
            https://docs.gitlab.com/ee/update/README.html#upgrade-paths

looking at the code of the check, this seems to occur when the gitlab version is a semver version and the /chart-info/gitlabVersion file does not exists.

the gitlabVersion configmap is not tagged to be installed as a preUpgrade hook.

This happens with argocd which does not distinguish between upgrades and installs, quote from teh docs:

Argo CD cannot know if it is running a first-time "install" or an "upgrade" - every operation is a "sync'. This means that, by default, apps that have pre-install and pre-upgrade will have those hooks run at the same time.

Steps to reproduce

here is how I try to install gitlabs with argocd: https://github.com/raffaelespazzoli/backstage-demo/tree/main/gitlab/ocp-gitlab

Configuration used

(Please provide a sanitized version of the configuration used wrapped in a code block (```yaml))

gitlab:
  certmanager:
    installCRDs: false
    install: false
    rbac:
      create: false

  nginx-ingress:
    enabled: false  

  gitlab:
    webservice:
      ingress:
        tls:
          secretName: gitlab-tls

  registry:
    ingress:
      tls:
        secretName: registry-tls

  minio:
    ingress:
      tls:
        secretName: minio-tls     

global:
  hosts:
    domain: apps.dummy
  ingress:
    enabled: false
    configureCertmanager: false
    tls:
      enabled: true

Current behavior

the upgrade checks fails

Expected behavior

the upgrade check is able to figure out that it's a first install and exits succefully.

Versions

  • Chart: (tagged version | branch | hash git rev-parse HEAD)
  • Platform:
    • Cloud: AWS
    • Self-hosted: OpenShift
  • Kubernetes: (kubectl version) Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.0", GitCommit:"cb303e613a121a29364f75cc67d3d580833a7479", GitTreeState:"archive", BuildDate:"2021-07-22T00:00:00Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"22+", GitVersion:"v1.22.0-rc.0+894a78b", GitCommit:"894a78b5538c3e96d7bdfabfa8b41430cbd6811e", GitTreeState:"clean", BuildDate:"2021-10-08T07:20:41Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}
  • Helm: (helm version) v3