Recent Sidekiq labeleing work effectively disabled per pod labelings
Summary
When using a configuration for sidekiq such as the below:
gitlab:
sidekiq:
pods:
- name: urgent-other
concurrency: 5
minReplicas: 5
maxReplicas: 10
nodeSelector:
type: urgent-other
podLabels:
deployment: sidekiq-urgent-other
shard: urgent-other
The podLabels end up removed instead of continuing to be included.
template:
metadata:
labels:
app: sidekiq
release: gitlab
queue-pod-name: urgent-other
+ app: sidekiq
+ chart: sidekiq-4.8.3
+ release: gitlab
+ heritage: Helm
+
stage: main
tier: sv
type: sidekiq
- deployment: sidekiq-urgent-other
- shard: urgent-other
Steps to reproduce
Upgrade the chart to master using the above configuration.
This bug was introduced in: !1727 (merged)
Edited by John Skarbek