Gitaly pods, pv and pvc are renamed in 4.8.0 chart, data are lost.

Summary

Seems that there is a huge bug in 4.8.0 helm chart ( gitaly pods are renamed from gitlab-gitaly-X to gitlab-gitaly-default-X, also pv and pvc are recreated ), gitaly data are lost, cuz of newly created pvs.

Steps to reproduce

Upgrade from 4.7.4 to 4.8.0

Configuration used

        praefect:
          enabled: true
           virtualStorages:
             - name: default
               gitalyReplicas: 1
           dbSecret:
             secret: gitlab-postgresql-password
             key: psql-password
           psql:
             host: {{ .Values.postgresql.host }}
             port: {{ .Values.postgresql.port }}
             user: {{ .Values.postgresql.username }}
             dbName: praefect
             sslMode: require

Current behavior

Gitaly pods are renamed from gitlab-gitaly-X to gitlab-gitaly-default-X, also pv and pvc are recreated

Expected behavior

Versions

  • Chart: 4.8.0
  • Platform:
    • Cloud: AKS
  • Kubernetes: (kubectl version)
    • Client: v1.18.6
    • Server: v1.18.10
  • Helm: (helm version)
    • Client: v3.2.4

Relevant logs

x