Upgrade to chart 4.5.0 failed
Summary
Can't upgrade to helm chart 4.5.0. Looks like typo (one space too much) in https://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/templates/_deprecations.tpl#L375.
4.5.1 has the same error.
Steps to reproduce
- Launch gitlab helm chart 4.4.4
- Upgrade to 4.5.0
Configuration used
Simplified but reproduced the error.
certmanager:
install: false
global:
edition: ce
hosts:
domain: domain.my
hostSuffix: test
externalIP: x.x.x.x
ingress:
configureCertmanager: false
enabled: false
nginx-ingress:
enabled: false
certmanager-issuer:
email: me@domain.my
gitlab-runner:
install: false
prometheus:
install: false
gitlab:
gitaly:
persistence:
enabled: false
webservice:
ingress:
enabled: false
registry:
ingress:
enabled: false
redis:
master:
persistence:
enabled: false
slave:
persistence:
enabled: false
postgresql:
persistence:
enabled: false
minio:
persistence:
enabled: false
Current behavior
Upgrade to 4.5.0 from 4.4.4
Wait helm template failed. Error: parse error in "gitlab/templates/_deprecations.tpl": template: gitlab/templates/_deprecations.tpl:375: unexpected "-" in end : exit status 1
Expected behavior
No Errors.
Versions
-
Chart: 4.5.0
-
Platform:
- Self-hosted: Rancher version v2.4.3 (684884c00)
-
Kubernetes: (
kubectl version
)- Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.8", GitCommit:"ec6eb119b81be488b030e849b9e64fda4caaf33c", GitTreeState:"clean", BuildDate:"2020-03-12T21:00:06Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
- Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.5", GitCommit:"e0fccafd69541e3750d460ba0f9743b90336f24f", GitTreeState:"clean", BuildDate:"2020-04-16T11:35:47Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
-
Rancher-Helm: (
rancher-helm version
)- Client: &version.Version{SemVer:"v2.16.5-rancher1", GitCommit:"cba158d2776ba1b4c26812521503eaa12b6170cd", GitTreeState:"clean"}
- Server: Error: could not find tiller (Looks like i need to fix this. But 4.4.4 work with that)
-
Helm: (
helm_v3 version
)- version.BuildInfo{Version:"v3.2.0", GitCommit:"e11b7ce3b12db2941e90399e874513fbd24bcb71", GitTreeState:"clean", GoVersion:"go1.13.10"}
Edited by Christian Eser