Gitlab Grafana installation not working

changed the description

changed title from Gitlab Grafana not instlled as service to Gitlab Grafana installation not working

moved from gitlab-org/gitlab#269775 (moved)

@Hassnain-Alvi The problem that you are having is that your global section is indented to much. Here is what your configuration should look like:

gitlab:
  migrations:
    enabled: true
  gitaly:
    persistence:
      enabled: true
      storageClass: store
      size: 500Gi
gitlab-runner:
  install: false
nginx-ingress:
  controller:
    service:
      type: NodePort
minio:
  persistence:
    enabled: true
    storageClass: store
certmanager:
  install: false
global:
  grafana:
    enabled: true
  ingress:
    configureCertmanager: false
  hosts:
    domain: internal.org
  edition: ce

There was also a nested gitlab group that should not have been there and a couple of things that should have been at the top level. I think that this is more of what you are looking for.

added awaiting feedback label

mentioned in issue gitlab-org/distribution/team-tasks#745 (closed)

added devopssystems groupdistribution labels

@ghickey Its not a problem as mentioned in one of my earlier ticket as well, regarding gitlab certificate, i am using umbrella chart in helm so gitlab is my chart name and nested gitlab is its configuration. Globals are picking up fine that's why in --dry-run and deployment it updates ingress rules correctly.

Problem is with the service, after deployment i don't see any grafana service but i see rules added fine in mnginx-ingress. If i set global to false in my current chart configuration, i don't see any changes in --dry-run

So the problem is with grafana, rest of the services deployed fine with same config as shown in kubectl get pods output. Do i have to include any other config to install grafana as a service and pod ?

added sectioncore platform label

Well you are partially correct there. There is no service, but that is because the Grafana chart is not being deployed. This is because global.grafana.enabled is not set to true. The default in the values.yaml of the GitLab chart is set to false by default. If the Grafana chart was being deployed, then you would have seen a great deal more Kubernetes objects with grafana in the name.

In your original configuration, you are defining gitlab.global.grafana.enabled not global.grafana.enabled. As I stated, you need to correct your indention to get the chart to deploy correctly.

@ghickey That's pretty strange what i did is i created another global config outside gitlab. and it worked and deployed grafana. The reason for keeping rest of the configuration same is because if i place outside gitlab root it installs certificate manager etc. and doesn't respect config Anyways this worked i logged into the grafaan and found out that integration is working fine but i don;t see any dashboard in grafana How can i enable grafana dashboards now? should work out of the box. I saw docs but not sure which config maps i need to update ?

At this point the Helm chart does not ship with any dashboards installed. There is still work to be done to convert the dashboards found in Omnibus to work for the Helm chart installs. I believe that there are some changes in the metrics names that need to be resolved.

You can add your own dashboards by adding them to a ConfigMap that is labelled with gitlab_grafana_dashboard. Those dashboards will remain present after an upgrade. Please see https://gitlab.com/gitlab-org/charts/gitlab/-/tree/master/doc/charts/gitlab/gitlab-grafana#dashboard-support for more information.

@ghickey I asked because i didn't understand that label part i fetched configmap from my cluster using kubectl and gitlab-ce-grafana-config-dashboards configmap exist there. Do i have to edit that configmap and add gitlab_grafaba_dashboard label there?

I. tried editing that configmap BTW but it doesn't let me save those changes got this message

A copy of your changes has been stored to "/tmp/kubectl-edit-ig4de.yaml"
error: Edit cancelled, no valid changes were saved.

not sure which part i need to change. Can you please guide me ion that? Thanks

The current chart does not create a ConfigMap for dashboards at all. There is one for datasource which is probably named gitlab-ce-grafana-datasource. So I am suspecting that the ConfigMap that you currently see is created by the Grafana chart. If you edit that ConfigMap, any changes will probably be overwritten by an upgrade.

Concerning editing the ConfigMap, the error that you reference tends to make me think that the YAML that you were pushing back to the Kubernetes API was probably malformed. Chances are that ConfigMap already had the label applied to it.

I would suggest that you create a new ConfigMap (you can call it anything you want) and just add the following label to it.

metadata:
  labels:
    gitlab_grafana_dashboard: "true"

That should do it for you.

@ghickey Added new configmap with following configuration:

apiVersion: v1
kind: ConfigMap
metadata:
  annotations:
    meta.helm.sh/release-name: gitlab-ce
    meta.helm.sh/release-namespace: default
  creationTimestamp: "2020-10-21T06:44:53Z"
  labels:
    gitlab_grafana_dashboard: "true"
  name: grafana-dashboard
  namespace: default
  resourceVersion: "1088713"
  selfLink: /api/v1/namespaces/default/configmaps/grafana-dashboard
  uid: f5816483-8e57-44c1-a76f-b498be18c4d5