Some portions of object storage configuration are templated when disabled

Summary

Portions of gitlab.yml.erb are templated despite the features being disabled. This does not align to the secret mounting behavior, resulting in the attempt to read files not present, and stopping Rails containers from starting.

This appears to stem from gitlab.appConfig.objectStorage.configuration populating the connection block if it exists not if it exists and is enabled

Steps to reproduce

Seen here #2269 (comment 401879089)

Configuration used

global:
  appConfig:
    dependencyProxy:
      enabled: false
      proxy_download: true
      bucket: gitlab-test-dependency-proxy-pzag
      connection:
        secret: gitlab-object-storage
        key: connection

Current behavior

gitlab.yml.erb is templated including the connection secret to be read, but the secret is not mounted. The Rails containers then fail to start.

Expected behavior

When a feature is disabled, the connection secret read is not templated into gitlab.yml.erb, as it will not be present.

Versions

• Chart: 4.3.0

Relevant logs

See logs in comment

cc @neckbeardprince