CI: Some environments not stopped if review_X did not succeed

Summary

On 3 July 2020, EKS deployments failed repeated due to resource contention. Upon inspection, it was found that 5 deployments existed that were either problematic, or not expected because of their age / branch had been merged.

We should find a way to stop all environments, regardless of "success" status.

Steps to reproduce

Environments that were running, and not stopped because review_X was not ✅

https://gitlab.com/gitlab-org/charts/gitlab/-/pipelines/152983212 https://gitlab.com/gitlab-org/charts/gitlab/-/pipelines/158813368 https://gitlab.com/gitlab-org/charts/gitlab/-/pipelines/162004928

Current behavior

Some environments don't stop if the review_X Job did not pass (helm "failed" or timed out)

Expected behavior

All review environments are stopped, just in case they're actually perfectly ""fine"" running deployments.

Versions

• Chart: 3c4f8b17
• Platform:
  • Cloud: GKE | EKS