Stable branches should be using Stable images, when possible
Summary
When possible, X-Y-stable
branches of these charts should be setting appVersion
of Chart.yaml
s to a stable tag whenever possible. This does occur once tags are present via release-tools
, but does not happen prior to that.
Example:
4-1-stable
branch runs a pipeline before being tagged with a release. release-tools
has not been run, tagging a version. Inside this branch, appVersion: master
. This results in the consumption of latest
images (#1201 (closed)) on a "stable" branch. The "expectation" should be that 4-1-stable
deploys 13-1-stable
images from the CNG.
Current behavior
X-Y-stable
branches deploy master
of CNG until releases are tagged via release-tools
Expected behavior
X-Y-stable
branches of the charts are deployed with A-B-stable
branches of CNG images, so long as said branch is present.
Relevant logs
apiVersion: v1
kind: Pod
metadata:
labels:
app: webservice
pod-template-hash: 7fcb89678c
release: gke-review-4-1-st-43zewa
name: gke-review-4-1-st-43zewa-webservice-7fcb89678c-rggxw
namespace: helm-charts-win
spec:
containers:
- name: webservice
image: registry.gitlab.com/gitlab-org/build/cng/gitlab-webservice-ee:latest
imagePullPolicy: Always
ci:
branch: 4-1-stable
job:
url: https://gitlab.com/gitlab-org/charts/gitlab/-/jobs/601029740
pipeline:
url: https://gitlab.com/gitlab-org/charts/gitlab/-/pipelines/157588474
sha: 2f187364f4a3269ae88de907828cc4fbee88a72c
title: |
Merge branch 'patch-1' into 'master'