Skip to content

Implement global.deployment.annotations in all GitLab owned sub-charts

Summary

Introduced by !893 (closed) as a peer to global.service.annotations, global.deployment.annotations serves to function as a means to produce annotations to all GitLab created charts as a part of the CNG. We should ensure this newly added functionality is included through out all the GitLab owned charts.

Configuration used

global:
  deployment:
    annotations:
      sample: t

Current behavior

---
# Source: gitlab/charts/registry/templates/deployment.yaml
apiVersion: apps/v1beta2
kind: Deployment
metadata:
  name: release-name-registry
  ...
  annotations:
    sample: t
spec:
...
---
# Source: gitlab/charts/gitlab/charts/gitlab-exporter/templates/deployment.yaml
apiVersion: apps/v1beta2
kind: Deployment
metadata:
  name: release-name-gitlab-exporter
  namespace: default
  labels:
    app: gitlab-exporter
    chart: gitlab-exporter-2.2.1
    release: release-name
    heritage: Tiller  
spec:
...

Expected behavior

---
# Source: gitlab/charts/registry/templates/deployment.yaml
apiVersion: apps/v1beta2
kind: Deployment
metadata:
  name: release-name-registry
  ...
  annotations:
    sample: t
spec:
...
---
# Source: gitlab/charts/gitlab/charts/gitlab-exporter/templates/deployment.yaml
apiVersion: apps/v1beta2
kind: Deployment
metadata:
  name: release-name-gitlab-exporter
  ...
  annotations:
    sample: t 
spec:
...

Versions

cc @jarv

Edited by Jason Plum