Windows (CRLF) Line Endings not supported.

Summary

When checking out the GitLab Charts in some cases and editors they can be moved to Windows CRLF Line endings. This causes the replace newline code in our charts to fail terribly. We should add a replace for windows line endings.

This can be observed here - https://gitlab.com/charts/gitlab/blob/master/charts/shared-secrets/templates/_generate_secrets.sh#L29 - Where we are only replacing \n, Windows/DOS uses \r\n. So on a Windows machine when Helm runs it will still read the \r line endings breaking the charts entirely.

Steps to reproduce

Check out charts with Windows CRLF Line Endings. Run Chart. Watch Fireworks.

Current behavior

Same behavior of Steps to Reproduce.

Expected behavior

Check out charts with Windows CRLF Line Endings. Run Chart. ??? Success.

Versions

• Chart: 2-2-stable
• Platform:
  • Cloud: EKS
  • Self-hosted: EKS / Kubernetes
• Kubernetes: (kubectl version)
  • Client: V1.14.3
  • Server: V1.12.10-eks-2e569f
• Helm: (helm version)
  • Client: V2.12.2
  • Server: V2.14.2

Relevant logs

None