Skip to content

Resolve #2627 CNG: UBI Containers - LIBDIR not defined for users who do not use our build image

Steve Terhar requested to merge 2627-cng-ubi-containers-libdir-default-value into master

What does this MR do?

In the task runner UBI8 Dockerfile, modify: COPY scripts/lib/* ${LIBDIR}/ruby/vendor_ruby/ to add a default value for environments where LIBDIR is not defined.

Currently, if the UBI containers are built and LIBDIR is not defined, the files will be copied to /ruby/vendor_ruby instead of the correct location. This causes the gitlab backup command to fail.

I selected /usr/lib as the default value as a first iteration. The goal here was the smallest possible change that would fix the immediate issue (failed backups).

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened

Closes gitlab-org/charts/gitlab#2627 (closed)

Edited by Steve Terhar

Merge request reports