danger-review
Passed Started
by
@WarheadsSE
Jason Plum
1Running with gitlab-runner 17.4.0~pre.110.g27400594 (27400594)2 on blue-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 1zzGUpzq, system ID: s_fc31da7ae46e3 feature flags: FF_NETWORK_PER_BUILD:true, FF_DISABLE_UMASK_FOR_DOCKER_EXECUTOR:true4Resolving secrets6Using Docker executor with image ruby:3.3 ...7Pulling docker image ruby:3.3 ...8Using docker image sha256:a4cbcc423dac397f93ab17fb190b8f6526597e3e55a1f99cfce239a9dbbbc76f for ruby:3.3 with digest ruby@sha256:dc4e58bf5fd54385441b663193275235a37d62b7f8c2cb58a5a043c1f830d1fd ...9Not using umask - FF_DISABLE_UMASK_FOR_DOCKER_EXECUTOR is set!11Running on runner-1zzgupzq-project-4359271-concurrent-0 via runner-1zzgupzq-private-1727698528-9b59cbdb...13Fetching changes...14Initialized empty Git repository in /builds/gitlab-org/build/CNG/.git/15Created fresh repository.16Checking out 0f4475b5 as detached HEAD (ref is refs/merge-requests/2045/merge)...17Skipping Git submodules setup18$ git remote set-url origin "${CI_REPOSITORY_URL}"20Using docker image sha256:a4cbcc423dac397f93ab17fb190b8f6526597e3e55a1f99cfce239a9dbbbc76f for ruby:3.3 with digest ruby@sha256:dc4e58bf5fd54385441b663193275235a37d62b7f8c2cb58a5a043c1f830d1fd ...21$ [[ -f "Gemfile" ]] || (bundle init && bundle add gitlab-dangerfiles --version "")22Writing new Gemfile to /builds/gitlab-org/build/CNG/Gemfile23Fetching gem metadata from https://rubygems.org/..............24Resolving dependencies...25Fetching gem metadata from https://rubygems.org/...........26Fetching rake 13.2.127Installing rake 13.2.128Fetching public_suffix 6.0.129Fetching bigdecimal 3.1.830Installing bigdecimal 3.1.8 with native extensions31Installing public_suffix 6.0.132Fetching claide 1.1.033Installing claide 1.1.034Fetching colored2 3.1.235Installing colored2 3.1.236Fetching nap 1.1.037Installing nap 1.1.038Fetching open4 1.3.439Installing open4 1.3.440Fetching csv 3.3.041Installing csv 3.3.042Fetching uri 0.13.143Installing uri 0.13.144Fetching json 2.7.245Installing json 2.7.2 with native extensions46Fetching logger 1.6.147Installing logger 1.6.148Fetching rchardet 1.8.049Installing rchardet 1.8.050Fetching rexml 3.3.851Installing rexml 3.3.852Fetching unicode-display_width 2.6.053Installing unicode-display_width 2.6.054Fetching mini_mime 1.1.555Installing mini_mime 1.1.556Fetching addressable 2.8.757Installing addressable 2.8.758Fetching cork 0.3.059Installing cork 0.3.060Fetching net-http 0.4.161Installing net-http 0.4.162Fetching kramdown 2.4.063Installing kramdown 2.4.064Fetching terminal-table 3.0.265Installing terminal-table 3.0.266Fetching git 1.19.167Installing git 1.19.168Fetching claide-plugins 0.9.269Installing claide-plugins 0.9.270Fetching faraday-net_http 3.3.071Installing faraday-net_http 3.3.072Fetching kramdown-parser-gfm 1.1.073Installing kramdown-parser-gfm 1.1.074Fetching faraday 2.12.075Installing faraday 2.12.076Fetching faraday-http-cache 2.5.177Installing faraday-http-cache 2.5.178Fetching sawyer 0.9.279Installing sawyer 0.9.280Fetching octokit 9.1.081Installing octokit 9.1.082Fetching danger 9.5.083Installing danger 9.5.084Fetching multi_xml 0.7.185Installing multi_xml 0.7.186Fetching httparty 0.22.087Installing httparty 0.22.088Fetching gitlab 5.0.089Installing gitlab 5.0.090Fetching danger-gitlab 9.0.091Installing danger-gitlab 9.0.092Fetching gitlab-dangerfiles 4.8.093Installing gitlab-dangerfiles 4.8.094$ [[ ! -f "Gemfile.lock" ]] || bundle config set --local frozen "true"95$ bundle install96Bundle complete! 1 Gemfile dependency, 35 gems now installed.97Use `bundle info [gemname]` to see where a bundled gem is installed.98$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command99$ if [ -z "${GITLAB_API_TOKEN}" ]; then # collapsed multi-line command100To use retry middleware with Faraday v2.0+, install `faraday-retry` gem101To use multipart middleware with Faraday v2.0+, install `faraday-multipart` gem; note: this is used by the ManageGHES client for uploading licenses102/usr/local/bundle/gems/danger-9.5.0/lib/danger/commands/local.rb:1: warning: pstore was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.103You can add pstore to your Gemfile or gemspec to silence this warning.104/usr/local/bundle/gems/danger-9.5.0/lib/danger/request_sources/vsts.rb:2: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.105You can add base64 to your Gemfile or gemspec to silence this warning.106Importing rule changelog at /usr/local/bundle/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/changelog107Importing rule changes_size at /usr/local/bundle/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/changes_size108/builds/gitlab-org/build/CNG/danger/reviewers/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::MESSAGE109/builds/gitlab-org/build/CNG/danger/go_upgrade/Dangerfile:1: warning: previous definition of MESSAGE was here110/usr/local/bundle/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/simple_roulette/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::MESSAGE111/builds/gitlab-org/build/CNG/danger/reviewers/Dangerfile:3: warning: previous definition of MESSAGE was here112Importing rule commit_messages at /usr/local/bundle/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/commit_messages113Importing rule commits_counter at /usr/local/bundle/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/commits_counter114Importing rule go_upgrade at /builds/gitlab-org/build/CNG/danger/go_upgrade115Importing rule metadata at /usr/local/bundle/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/metadata116Importing rule reviewers at /builds/gitlab-org/build/CNG/danger/reviewers117Importing rule ruby_upgrade at /builds/gitlab-org/build/CNG/danger/ruby_upgrade118Importing rule simple_roulette at /usr/local/bundle/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/simple_roulette119Importing rule type_label at /usr/local/bundle/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/type_label120Importing rule z_add_labels at /usr/local/bundle/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/z_add_labels121Importing rule z_retry_link at /usr/local/bundle/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/z_retry_link122Results:123Messages:124- [ ] Please add the ~"workflow::ready for review" label once you think the MR is ready to for an initial review, and assign125a reviewer based on the Reviewer Roulette suggestion below.126If from a community member, ask that the ~"Community contribution" label be added as well.127Merge requests are handled according to the workflow documented in our [handbook](https://about.gitlab.com/handbook/engineering/infrastructure/core-platform/systems/distribution/merge_requests.html#workflow) and should receive a response within the limit documented in our [First-response SLO](https://about.gitlab.com/handbook/engineering/workflow/code-review/#first-response-slo).128If you don't receive a response, please mention `@gitlab-org/distribution`, or one of our [Project Maintainers](https://about.gitlab.com/handbook/engineering/projects/#gitlab-chart)129Markdown:130## Reviewer roulette131Changes that require review have been detected! A merge request is normally132reviewed by both a reviewer and a maintainer in its primary category and by a133maintainer in all other categories.134To spread load more evenly across eligible reviewers, Danger has picked a candidate for each135review slot. Feel free to136[override these selections](https://about.gitlab.com/handbook/engineering/projects/#CNG)137if you think someone else would be better-suited138or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/?currentProject=CNG)139to find other available reviewers.140To read more on how to use the reviewer roulette, please take a look at the141[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)142and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).143Please consider assigning a reviewer or maintainer who is a144[domain expert](https://about.gitlab.com/handbook/engineering/projects/#CNG)145in the area of the merge request.146Once you've decided who will review this merge request, mention them as you147normally would! Danger does not automatically notify them for you.148| Reviewer | Maintainer |149| -------- | ---------- |150| `@lucus.li` [{width=12}](https://gitlab.com/lucus.li) {width=12} (UTC+9, 13 hours ahead of author) | `@rmarshall` [{width=12}](https://gitlab.com/rmarshall) {width=12} (UTC-4, same timezone as author) |151**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/build/CNG/-/jobs/7956922440) that generated this comment.**153Job succeeded