Commit c2d3ca98 authored by Zubeen's avatar Zubeen 🤖 Committed by Timo Furrer
Browse files

fix: Type Mismatch in UpdateSettingsOptions for SentryEnabled 

Changelog: Improvements
parent b2b57f25

settings.go

+1 −1
Original line number Diff line number Diff line
@@ -835,7 +835,7 @@ type UpdateSettingsOptions struct { 
	SendUserConfirmationEmail                             *bool                                   `url:"send_user_confirmation_email,omitempty" json:"send_user_confirmation_email,omitempty"`

	SentryClientsideDSN                                   *string                                 `url:"sentry_clientside_dsn,omitempty" json:"sentry_clientside_dsn,omitempty"`

	SentryDSN                                             *string                                 `url:"sentry_dsn,omitempty" json:"sentry_dsn,omitempty"`

	SentryEnabled                                         *string                                 `url:"sentry_enabled,omitempty" json:"sentry_enabled,omitempty"`

	SentryEnabled                                         *bool                                   `url:"sentry_enabled,omitempty" json:"sentry_enabled,omitempty"`

	SentryEnvironment                                     *string                                 `url:"sentry_environment,omitempty" json:"sentry_environment,omitempty"`

	ServiceAccessTokensExpirationEnforced                 *bool                                   `url:"service_access_tokens_expiration_enforced,omitempty" json:"service_access_tokens_expiration_enforced,omitempty"`

	SessionExpireDelay                                    *int64                                  `url:"session_expire_delay,omitempty" json:"session_expire_delay,omitempty"`

settings_test.go

+30 −0
Original line number Diff line number Diff line
@@ -209,3 +209,33 @@ func TestGetSettings_AnonymousSearchesAllowed(t *testing.T) { 


	assert.True(t, settings.AnonymousSearchesAllowed)

}



func TestSettings_SentryEnabled(t *testing.T) {

	t.Parallel()

	mux, client := setup(t)



	mux.HandleFunc("/api/v4/application/settings", func(w http.ResponseWriter, r *http.Request) {

		if r.Method == http.MethodGet {

			testMethod(t, r, http.MethodGet)

			fmt.Fprint(w, `{"id":1, "sentry_enabled": false}`)

			return

		}



		if r.Method == http.MethodPut {

			testMethod(t, r, http.MethodPut)

			fmt.Fprint(w, `{"id":1, "sentry_enabled": true}`)

		}

	})



	// Get current settings

	settings, _, err := client.Settings.GetSettings()

	assert.NoError(t, err)

	assert.False(t, settings.SentryEnabled)



	// Update the setting

	updated, _, err := client.Settings.UpdateSettings(&UpdateSettingsOptions{

		SentryEnabled: Ptr(true),

	})

	assert.NoError(t, err)

	assert.True(t, updated.SentryEnabled)

}