Verified Commit 6ed574d9 authored by Michael Eddington's avatar Michael Eddington Committed by GitLab
Browse files

fix: satisfy golangci-lint 2.13.1 

Changelog: Improvements
parent 861015ec

.gitlab-ci.yml

+2 −0
Original line number Diff line number Diff line
@@ -109,6 +109,8 @@ stages: 
        - go.sum

        - .gitlab-ci.yml

        - .gitlab/ci/*.yml

        - .tool-versions

        - .golangci.yml

        - buf.yaml

        - buf.gen.yaml

        - buf.lock

gitlab.go

+1 −1
Original line number Diff line number Diff line
@@ -933,7 +933,7 @@ func validateBaseURL(baseURL string) (*url.URL, error) { 
		}

	}



	if parsedURL.Scheme != "http" && parsedURL.Scheme != "https" { //nolint:goconst

	if parsedURL.Scheme != "http" && parsedURL.Scheme != "https" {

		return nil, &URLValidationError{

			URL:  baseURL,

			Err:  fmt.Errorf("unsupported scheme %q", parsedURL.Scheme),

types.go

+2 −2
Original line number Diff line number Diff line
@@ -554,7 +554,7 @@ func (t *ISOTime) UnmarshalJSON(data []byte) error { 


// EncodeValues implements the query.Encoder interface.

func (t *ISOTime) EncodeValues(key string, v *url.Values) error {

	if t == nil || (time.Time(*t)).IsZero() {

	if t == nil || time.Time(*t).IsZero() {

		return nil

	}

	v.Add(key, t.String())
@@ -694,7 +694,7 @@ const ( 
)



var notificationLevelNames = [...]string{

	"disabled", //nolint:goconst

	"disabled",

	"participating",

	"watch",

	"global",

workitems.go

+2 −2
Original line number Diff line number Diff line
@@ -749,11 +749,11 @@ func buildListWorkItemsQuery(fullPath string, opt *ListWorkItemsOptions) (string 
	}



	if opt.First != nil {

		qvars = append(qvars, workItemQueryVar{"first", "Int", opt.First}) //nolint:goconst

		qvars = append(qvars, workItemQueryVar{"first", "Int", opt.First})

	}



	if opt.Last != nil {

		qvars = append(qvars, workItemQueryVar{"last", "Int", opt.Last}) //nolint:goconst

		qvars = append(qvars, workItemQueryVar{"last", "Int", opt.Last})

	}



	varsMap["fullPath"] = fullPath