danger-review
Passed Started
by
@zzaakiirr
Zakir Dzhamaliddinov
1Running with gitlab-runner 17.0.0~pre.88.g761ae5dd (761ae5dd)2 on green-4.shared-gitlab-org.runners-manager.gitlab.com/default x5QiHUKw, system ID: s_b9637080a79e3 feature flags: FF_NETWORK_PER_BUILD:true4Resolving secrets6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:d10d211334d3c94a5e626cf961467431b7d3f3bd8b6109e5caf9357421c0117b for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14@sha256:3c4cd9a237deb59350b4836552151ba2aae96247034074c8f0c2ccaff4558cab ...11Running on runner-x5qihukw-project-41372369-concurrent-0 via runner-x5qihukw-shared-gitlab-org-1716993700-a1baa9a1...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-community/gitlab/.git/15Created fresh repository.16Checking out 38e4cc8d as detached HEAD (ref is 20381-add-trigram-indexes-on-email-column)...17Skipping Git submodules setup18$ git remote set-url origin "${CI_REPOSITORY_URL}"20Checking cache for ruby-gems-debian-bookworm-ruby-3.2...21WARNING: file does not exist 22Failed to extract cache23Checking cache for node-modules-debian-bookworm-test...24Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/41372369/node-modules-debian-bookworm-test 25Successfully extracted cache27Using docker image sha256:d10d211334d3c94a5e626cf961467431b7d3f3bd8b6109e5caf9357421c0117b for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.2.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14@sha256:3c4cd9a237deb59350b4836552151ba2aae96247034074c8f0c2ccaff4558cab ...28$ source scripts/utils.sh29$ bundle_install_script1430$ yarn_install_script1505$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command1507 * branch 20381-add-trigram-indexes-on-email-column -> FETCH_HEAD1508$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command1509Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/analytics_instrumentation.rb1510Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/bulk_database_actions.rb1511Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/change_column_default.rb1512Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/ci_templates.rb1513Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/clickhouse.rb1514Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/config_files.rb1515Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/customer_success.rb1516Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/database.rb1517Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/database_dictionary.rb1518Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/datateam.rb1519Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/experiments.rb1520Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/feature_flag.rb1521Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/gitlab_schema_validation.rb1522Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/ignored_model_columns.rb1523Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/master_pipeline_status.rb1524Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/model_validations.rb1525Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/multiversion.rb1526Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/project_helper.rb1527Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/required_stops.rb1528Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/rubocop.rb1529Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/saas_feature.rb1530Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/sidekiq_args.rb1531Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/sidekiq_queues.rb1532Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/specs.rb1533Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/stable_branch.rb1534Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/todos.rb1535Importing rule analytics_instrumentation at /builds/gitlab-community/gitlab/danger/analytics_instrumentation1536Importing rule architecture at /builds/gitlab-community/gitlab/danger/architecture1537Importing rule bulk_database_actions at /builds/gitlab-community/gitlab/danger/bulk_database_actions1538Importing rule ce_ee_vue_templates at /builds/gitlab-community/gitlab/danger/ce_ee_vue_templates1539Importing rule change_column_default at /builds/gitlab-community/gitlab/danger/change_column_default1540Importing rule changelog at /builds/gitlab-community/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changelog1541Importing rule changes_size at /builds/gitlab-community/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changes_size1542Importing rule ci_config at /builds/gitlab-community/gitlab/danger/ci_config1543Importing rule ci_tables at /builds/gitlab-community/gitlab/danger/ci_tables1544Importing rule ci_templates at /builds/gitlab-community/gitlab/danger/ci_templates1545Importing rule clickhouse at /builds/gitlab-community/gitlab/danger/clickhouse1546Importing rule commit_messages at /builds/gitlab-community/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commit_messages1547Importing rule commits_counter at /builds/gitlab-community/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commits_counter1548Importing rule config_files at /builds/gitlab-community/gitlab/danger/config_files1549Importing rule customer_success at /builds/gitlab-community/gitlab/danger/customer_success1550Importing rule database at /builds/gitlab-community/gitlab/danger/database1551Importing rule datateam at /builds/gitlab-community/gitlab/danger/datateam1552Importing rule documentation at /builds/gitlab-community/gitlab/danger/documentation1553Importing rule duplicate_yarn_dependencies at /builds/gitlab-community/gitlab/danger/duplicate_yarn_dependencies1554Importing rule eslint at /builds/gitlab-community/gitlab/danger/eslint1555Importing rule experiments at /builds/gitlab-community/gitlab/danger/experiments1556Importing rule feature_flag at /builds/gitlab-community/gitlab/danger/feature_flag1557Importing rule gitaly at /builds/gitlab-community/gitlab/danger/gitaly1558Importing rule gitlab_schema_validation at /builds/gitlab-community/gitlab/danger/gitlab_schema_validation1559Importing rule ignored_model_columns at /builds/gitlab-community/gitlab/danger/ignored_model_columns1560Importing rule master_pipeline_status at /builds/gitlab-community/gitlab/danger/master_pipeline_status1561Importing rule metadata at /builds/gitlab-community/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/metadata1562Importing rule model_validations at /builds/gitlab-community/gitlab/danger/model_validations1563Importing rule multiversion at /builds/gitlab-community/gitlab/danger/multiversion1564Importing rule pipeline at /builds/gitlab-community/gitlab/danger/pipeline1565Importing rule pipeline_config at /builds/gitlab-community/gitlab/danger/pipeline_config1566Importing rule prettier at /builds/gitlab-community/gitlab/danger/prettier1567Importing rule qa_selector at /builds/gitlab-community/gitlab/danger/qa_selector1568Importing rule required_stops at /builds/gitlab-community/gitlab/danger/required_stops1569Importing rule roulette at /builds/gitlab-community/gitlab/danger/roulette1570Importing rule rubocop at /builds/gitlab-community/gitlab/danger/rubocop1571Importing rule rubygems at /builds/gitlab-community/gitlab/danger/rubygems1572Importing rule saas_feature at /builds/gitlab-community/gitlab/danger/saas_feature1573Importing rule sidekiq_args at /builds/gitlab-community/gitlab/danger/sidekiq_args1574Importing rule sidekiq_queues at /builds/gitlab-community/gitlab/danger/sidekiq_queues1575Importing rule specialization_labels at /builds/gitlab-community/gitlab/danger/specialization_labels1576Importing rule specs at /builds/gitlab-community/gitlab/danger/specs1577Importing rule stable_branch_patch at /builds/gitlab-community/gitlab/danger/stable_branch_patch1578Importing rule tailwindcss at /builds/gitlab-community/gitlab/danger/tailwindcss1579Rebuilding...1580Done in 6238ms.1581Importing rule todos at /builds/gitlab-community/gitlab/danger/todos1582Importing rule type_label at /builds/gitlab-community/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/type_label1583Importing rule utility_css at /builds/gitlab-community/gitlab/danger/utility_css1584Importing rule vue_shared_documentation at /builds/gitlab-community/gitlab/danger/vue_shared_documentation1585Importing rule z_add_labels at /builds/gitlab-community/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_add_labels1586Importing rule z_retry_link at /builds/gitlab-community/gitlab/vendor/ruby/3.2.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_retry_link1587Results:1588Warnings:1589- [ ] ⌛ **Migration Timestamp Out of Date**1590The following migrations have timestamps that are over three weeks old:1591* db/post_migrate/20240507161859_add_trigram_index_on_public_email_for_users.rb1592* db/post_migrate/20240507162033_add_trigram_index_on_email_for_users.rb1593* db/post_migrate/20240507162310_add_trigram_index_on_email_for_emails.rb1594Please double check the timestamps and update them if possible. [Why does this matter?](https://docs.gitlab.com/ee/development/migration_style_guide.html#migration-timestamp-age)1595- [ ] You've made some app changes, but didn't add any tests.1596That's OK as long as you're refactoring existing code,1597but please consider adding any of the ~"maintenance::pipelines", ~"maintenance::refactor", ~"maintenance::workflow", ~"documentation", ~"QA" labels.1598Messages:1599- [ ] This merge request adds or changes files that require a review from the [Database team](https://gitlab.com/groups/gl-database/-/group_members).1600Markdown:1601This merge request requires a database review. To make sure these1602changes are reviewed, take the following steps:16031. Ensure the merge request has ~database and ~"database::review pending" labels.1604 If the merge request modifies database files, Danger will do this for you.16051. Prepare your MR for database review according to the1606 [docs](https://docs.gitlab.com/ee/development/database_review.html#how-to-prepare-the-merge-request-for-a-database-review).16071. Assign and mention the database reviewer suggested by Reviewer Roulette.1608The following files require a review from the Database team:1609* `db/post_migrate/20240507161859_add_trigram_index_on_public_email_for_users.rb`1610* `db/post_migrate/20240507162033_add_trigram_index_on_email_for_users.rb`1611* `db/post_migrate/20240507162310_add_trigram_index_on_email_for_emails.rb`1612* `db/schema_migrations/20240507161859`1613* `db/schema_migrations/20240507162033`1614* `db/schema_migrations/20240507162310`1615* `db/docs/emails.yml`1616* `db/docs/users.yml`1617* `db/structure.sql`1618## Reviewer roulette1619| Category | Reviewer | Maintainer |1620| -------- | -------- | ---------- |1621| ~"database" | `@ck3g` [{width=12}](https://gitlab.com/ck3g) {width=12} (UTC+2) | `@tigerwnz` [{width=12}](https://gitlab.com/tigerwnz) {width=12} (UTC+10) |1622**Please check reviewer's status!**1623- {width=12} Reviewer is available!1624- {width=12} Reviewer is unavailable!1625Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)1626for guidance on how you can benefit from the Reviewer Roulette, or use the1627[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)1628to find other available reviewers.1629**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-community/gitlab/-/jobs/6972245585) that generated this comment.**1631Not uploading cache ruby-gems-debian-bookworm-ruby-3.2 due to policy1632Not uploading cache node-modules-debian-bookworm-test due to policy1634Job succeeded 
