danger-review
Passed Started
by
@archish27
Archish Thakkar
1Running with gitlab-runner 16.11.0~pre.21.gaa21be2d (aa21be2d)2 on blue-5.shared-gitlab-org.runners-manager.gitlab.com/default ynF9_MVqW, system ID: s_f09ddfa72a073 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Dialing instance https://www.googleapis.com/compute/v1/projects/gitlab-r-saas-l-m-amd64-org-5/zones/us-east1-c/instances/blue-default-1f2d03d8d6f4ed4c...7Instance https://www.googleapis.com/compute/v1/projects/gitlab-r-saas-l-m-amd64-org-5/zones/us-east1-c/instances/blue-default-1f2d03d8d6f4ed4c connected8Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...9Authenticating with credentials from job payload (GitLab Registry)10Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...11Using docker image sha256:3c243e405fd2672acb3e11eafb33771abc7a592c28dcc64a91acd9df58ebe92b for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14@sha256:ccb78a5779701a290c07cce3388c5f6eadef4200c487134015aa5d32c3d6a966 ...13Running on runner-ynf9mvqw-project-41372369-concurrent-22 via runners-manager-shared-gitlab-org-blue-5...15Fetching changes with git depth set to 20...16Initialized empty Git repository in /builds/gitlab-community/gitlab/.git/17Created fresh repository.18Checking out 22310fd1 as detached HEAD (ref is 239356-Lint/AmbiguousOperatorPrecedence3)...19Skipping Git submodules setup20$ git remote set-url origin "${CI_REPOSITORY_URL}"22Checking cache for ruby-gems-debian-bookworm-ruby-3.1...23Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/41372369/ruby-gems-debian-bookworm-ruby-3.1 24Successfully extracted cache25Checking cache for node-modules-debian-bookworm-test...26Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/41372369/node-modules-debian-bookworm-test 27Successfully extracted cache29Using docker image sha256:3c243e405fd2672acb3e11eafb33771abc7a592c28dcc64a91acd9df58ebe92b for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14@sha256:ccb78a5779701a290c07cce3388c5f6eadef4200c487134015aa5d32c3d6a966 ...30$ source scripts/utils.sh31$ bundle_install_script745$ yarn_install_script819$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command821 * branch 239356-Lint/AmbiguousOperatorPrecedence3 -> FETCH_HEAD822$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command823Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/analytics_instrumentation.rb824Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/bulk_database_actions.rb825Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/change_column_default.rb826Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/ci_templates.rb827Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/clickhouse.rb828Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/config_files.rb829Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/customer_success.rb830Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/database.rb831Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/database_dictionary.rb832Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/datateam.rb833Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/experiments.rb834Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/feature_flag.rb835Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/gitlab_schema_validation.rb836Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/ignored_model_columns.rb837Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/master_pipeline_status.rb838Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/model_validations.rb839Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/multiversion.rb840Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/project_helper.rb841Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/required_stops.rb842Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/rubocop.rb843Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/saas_feature.rb844Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/sidekiq_args.rb845Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/sidekiq_queues.rb846Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/specs.rb847Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/stable_branch.rb848Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/todos.rb849Importing rule analytics_instrumentation at /builds/gitlab-community/gitlab/danger/analytics_instrumentation850Importing rule architecture at /builds/gitlab-community/gitlab/danger/architecture851Importing rule bulk_database_actions at /builds/gitlab-community/gitlab/danger/bulk_database_actions852Importing rule ce_ee_vue_templates at /builds/gitlab-community/gitlab/danger/ce_ee_vue_templates853Importing rule change_column_default at /builds/gitlab-community/gitlab/danger/change_column_default854Importing rule changelog at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changelog855Importing rule changes_size at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changes_size856Importing rule ci_config at /builds/gitlab-community/gitlab/danger/ci_config857Importing rule ci_tables at /builds/gitlab-community/gitlab/danger/ci_tables858Importing rule ci_templates at /builds/gitlab-community/gitlab/danger/ci_templates859Importing rule clickhouse at /builds/gitlab-community/gitlab/danger/clickhouse860Importing rule commit_messages at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commit_messages861Importing rule commits_counter at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commits_counter862Importing rule config_files at /builds/gitlab-community/gitlab/danger/config_files863Importing rule customer_success at /builds/gitlab-community/gitlab/danger/customer_success864Importing rule database at /builds/gitlab-community/gitlab/danger/database865Importing rule datateam at /builds/gitlab-community/gitlab/danger/datateam866Importing rule documentation at /builds/gitlab-community/gitlab/danger/documentation867Importing rule duplicate_yarn_dependencies at /builds/gitlab-community/gitlab/danger/duplicate_yarn_dependencies868Importing rule eslint at /builds/gitlab-community/gitlab/danger/eslint869Importing rule experiments at /builds/gitlab-community/gitlab/danger/experiments870Importing rule feature_flag at /builds/gitlab-community/gitlab/danger/feature_flag871Importing rule gitaly at /builds/gitlab-community/gitlab/danger/gitaly872Importing rule gitlab_schema_validation at /builds/gitlab-community/gitlab/danger/gitlab_schema_validation873Importing rule ignored_model_columns at /builds/gitlab-community/gitlab/danger/ignored_model_columns874Importing rule master_pipeline_status at /builds/gitlab-community/gitlab/danger/master_pipeline_status875Importing rule metadata at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/metadata876Importing rule model_validations at /builds/gitlab-community/gitlab/danger/model_validations877Importing rule multiversion at /builds/gitlab-community/gitlab/danger/multiversion878Importing rule pipeline at /builds/gitlab-community/gitlab/danger/pipeline879Importing rule prettier at /builds/gitlab-community/gitlab/danger/prettier880Importing rule qa_selector at /builds/gitlab-community/gitlab/danger/qa_selector881Importing rule required_stops at /builds/gitlab-community/gitlab/danger/required_stops882Importing rule roulette at /builds/gitlab-community/gitlab/danger/roulette883Importing rule rubocop at /builds/gitlab-community/gitlab/danger/rubocop884Importing rule rubygems at /builds/gitlab-community/gitlab/danger/rubygems885Importing rule saas_feature at /builds/gitlab-community/gitlab/danger/saas_feature886Importing rule sidekiq_args at /builds/gitlab-community/gitlab/danger/sidekiq_args887Importing rule sidekiq_queues at /builds/gitlab-community/gitlab/danger/sidekiq_queues888Importing rule specialization_labels at /builds/gitlab-community/gitlab/danger/specialization_labels889Importing rule specs at /builds/gitlab-community/gitlab/danger/specs890Importing rule stable_branch_patch at /builds/gitlab-community/gitlab/danger/stable_branch_patch891Importing rule tailwindcss at /builds/gitlab-community/gitlab/danger/tailwindcss892Rebuilding...893Done in 5233ms.894Importing rule todos at /builds/gitlab-community/gitlab/danger/todos895Importing rule type_label at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/type_label896Importing rule utility_css at /builds/gitlab-community/gitlab/danger/utility_css897Importing rule vue_shared_documentation at /builds/gitlab-community/gitlab/danger/vue_shared_documentation898Importing rule z_add_labels at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_add_labels899Importing rule z_retry_link at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_retry_link900Results:901Warnings:902- [ ] This merge request does not refer to an existing milestone.903- [ ] You've made some app changes, but didn't add any tests.904That's OK as long as you're refactoring existing code,905but please consider adding any of the ~"maintenance::pipelines", ~"maintenance::refactor", ~"maintenance::workflow", ~"documentation", ~"QA" labels.906- [ ] Labels missing: please ask a reviewer or maintainer to add ~"backend" to this merge request.907Markdown:908## Reviewer roulette909| Category | Reviewer | Maintainer |910| -------- | -------- | ---------- |911| ~"backend" | `@imand3r` [{width=12}](https://gitlab.com/imand3r) {width=12} (UTC-7) | `@mkozono` [{width=12}](https://gitlab.com/mkozono) {width=12} (UTC-10) |912| ~"Backend Static Code Analysis" | Reviewer review is optional for ~"Backend Static Code Analysis" | `@nao.hashizume` [{width=12}](https://gitlab.com/nao.hashizume) {width=12} (UTC-7) |913| ~"Tooling" | Reviewer review is optional for ~"Tooling" | `@ddieulivol` [{width=12}](https://gitlab.com/ddieulivol) {width=12} (UTC+2) |914| ~"group::authorization" | Reviewer review is optional for ~"group::authorization" | `@hmehra` [{width=12}](https://gitlab.com/hmehra) {width=12} (UTC+10) |915**Please check reviewer's status!**916- {width=12} Reviewer is available!917- {width=12} Reviewer is unavailable!918Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)919for guidance on how you can benefit from the Reviewer Roulette, or use the920[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)921to find other available reviewers.922**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-community/gitlab/-/jobs/6734098695) that generated this comment.**924Not uploading cache ruby-gems-debian-bookworm-ruby-3.1 due to policy925Not uploading cache node-modules-debian-bookworm-test due to policy927Job succeeded 
