danger-review
Passed Started
by
@kevin.gosa
Kevin-Damian Gosa
1Running with gitlab-runner 16.11.0~pre.21.gaa21be2d (aa21be2d)2 on blue-4.shared-gitlab-org.runners-manager.gitlab.com/default 8cwZ3F43, system ID: s_df0f7e24ca8b3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:c86779390e67e73100497cb604c92e8ab415805b76a9fe0bcd5a91d5d7b1c962 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:dfd5d48cb91c5028cc6b96d9e311a586519e59eb29d513d9c8be6e16f31faac9 ...11Running on runner-8cwz3f43-project-41372369-concurrent-0 via runner-8cwz3f43-shared-gitlab-org-1713176165-000caa36...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-community/gitlab/.git/15Created fresh repository.16Checking out a8bc3a3a as detached HEAD (ref is 429449_expose_short_token_to_ci)...17Skipping Git submodules setup18$ git remote set-url origin "${CI_REPOSITORY_URL}"20Checking cache for ruby-gems-debian-bookworm-ruby-3.1...21Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/41372369/ruby-gems-debian-bookworm-ruby-3.1 22Successfully extracted cache23Checking cache for node-modules-debian-bookworm-test...24Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/41372369/node-modules-debian-bookworm-test 25Successfully extracted cache27Using docker image sha256:c86779390e67e73100497cb604c92e8ab415805b76a9fe0bcd5a91d5d7b1c962 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:dfd5d48cb91c5028cc6b96d9e311a586519e59eb29d513d9c8be6e16f31faac9 ...28$ source scripts/utils.sh29$ bundle_install_script "--with danger"712$ yarn_install_script786$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command788 * branch 429449_expose_short_token_to_ci -> FETCH_HEAD789$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command790Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/analytics_instrumentation.rb791Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/bulk_database_actions.rb792Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/change_column_default.rb793Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/ci_templates.rb794Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/clickhouse.rb795Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/config_files.rb796Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/customer_success.rb797Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/database.rb798Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/database_dictionary.rb799Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/datateam.rb800Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/experiments.rb801Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/feature_flag.rb802Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/gitlab_schema_validation.rb803Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/ignored_model_columns.rb804Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/master_pipeline_status.rb805Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/model_validations.rb806Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/multiversion.rb807Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/project_helper.rb808Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/required_stops.rb809Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/rubocop.rb810Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/saas_feature.rb811Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/sidekiq_args.rb812Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/sidekiq_queues.rb813Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/specs.rb814Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/stable_branch.rb815Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/todos.rb816Importing rule analytics_instrumentation at /builds/gitlab-community/gitlab/danger/analytics_instrumentation817Importing rule architecture at /builds/gitlab-community/gitlab/danger/architecture818Importing rule bulk_database_actions at /builds/gitlab-community/gitlab/danger/bulk_database_actions819Importing rule ce_ee_vue_templates at /builds/gitlab-community/gitlab/danger/ce_ee_vue_templates820Importing rule change_column_default at /builds/gitlab-community/gitlab/danger/change_column_default821Importing rule changelog at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changelog822Importing rule changes_size at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changes_size823Importing rule ci_config at /builds/gitlab-community/gitlab/danger/ci_config824Importing rule ci_tables at /builds/gitlab-community/gitlab/danger/ci_tables825Importing rule ci_templates at /builds/gitlab-community/gitlab/danger/ci_templates826Importing rule clickhouse at /builds/gitlab-community/gitlab/danger/clickhouse827Importing rule commit_messages at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commit_messages828Importing rule commits_counter at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commits_counter829Importing rule config_files at /builds/gitlab-community/gitlab/danger/config_files830Importing rule customer_success at /builds/gitlab-community/gitlab/danger/customer_success831Importing rule database at /builds/gitlab-community/gitlab/danger/database832Importing rule datateam at /builds/gitlab-community/gitlab/danger/datateam833Importing rule documentation at /builds/gitlab-community/gitlab/danger/documentation834Importing rule duplicate_yarn_dependencies at /builds/gitlab-community/gitlab/danger/duplicate_yarn_dependencies835Importing rule eslint at /builds/gitlab-community/gitlab/danger/eslint836Importing rule experiments at /builds/gitlab-community/gitlab/danger/experiments837Importing rule feature_flag at /builds/gitlab-community/gitlab/danger/feature_flag838Importing rule gitaly at /builds/gitlab-community/gitlab/danger/gitaly839Importing rule gitlab_schema_validation at /builds/gitlab-community/gitlab/danger/gitlab_schema_validation840Importing rule ignored_model_columns at /builds/gitlab-community/gitlab/danger/ignored_model_columns841Importing rule master_pipeline_status at /builds/gitlab-community/gitlab/danger/master_pipeline_status842Importing rule metadata at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/metadata843Importing rule model_validations at /builds/gitlab-community/gitlab/danger/model_validations844Importing rule multiversion at /builds/gitlab-community/gitlab/danger/multiversion845Importing rule pipeline at /builds/gitlab-community/gitlab/danger/pipeline846Importing rule prettier at /builds/gitlab-community/gitlab/danger/prettier847Importing rule qa_selector at /builds/gitlab-community/gitlab/danger/qa_selector848Importing rule required_stops at /builds/gitlab-community/gitlab/danger/required_stops849Importing rule roulette at /builds/gitlab-community/gitlab/danger/roulette850Importing rule rubocop at /builds/gitlab-community/gitlab/danger/rubocop851Importing rule rubygems at /builds/gitlab-community/gitlab/danger/rubygems852Importing rule saas_feature at /builds/gitlab-community/gitlab/danger/saas_feature853Importing rule sidekiq_args at /builds/gitlab-community/gitlab/danger/sidekiq_args854Importing rule sidekiq_queues at /builds/gitlab-community/gitlab/danger/sidekiq_queues855Importing rule specialization_labels at /builds/gitlab-community/gitlab/danger/specialization_labels856Importing rule specs at /builds/gitlab-community/gitlab/danger/specs857Importing rule stable_branch_patch at /builds/gitlab-community/gitlab/danger/stable_branch_patch858Importing rule todos at /builds/gitlab-community/gitlab/danger/todos859Importing rule type_label at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/type_label860Importing rule utility_css at /builds/gitlab-community/gitlab/danger/utility_css861Importing rule vue_shared_documentation at /builds/gitlab-community/gitlab/danger/vue_shared_documentation862Importing rule z_add_labels at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_add_labels863Importing rule z_retry_link at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_retry_link864Results:865Warnings:866- [ ] There were no new or modified feature flag YAML files detected in this MR.867If the changes here are already controlled under an existing feature flag, please add868the ~"feature flag::exists". Otherwise, if you think the changes here don't need869to be under a feature flag, please add the label ~"feature flag::skipped", and870add a short comment about why we skipped the feature flag.871For guidance on when to use a feature flag, please see the [documentation](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#when-to-use-feature-flags).872Messages:873- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.874Markdown:875## Documentation review876The following files require a review from a technical writer:877* `doc/ci/variables/predefined_variables.md` ([Link to current live version](https://docs.gitlab.com/ee/ci/variables/predefined_variables/))878The review does not need to block merging this merge request. See the:879- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.880- The [Technical Writer assigned](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments) for that stage and group.881- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.882## Reviewer roulette883| Category | Reviewer | Maintainer |884| -------- | -------- | ---------- |885| ~"backend" | `@ahegyi` [{width=12}](https://gitlab.com/ahegyi) {width=12} (UTC+2) | `@suraj_tripathy` [{width=12}](https://gitlab.com/suraj_tripathy) {width=12} (UTC+5.5) |886| ~"Verify" | Reviewer review is optional for ~"Verify" | `@grzesiek` [{width=12}](https://gitlab.com/grzesiek) {width=12} (UTC+2) |887**Please check reviewer's status!**888-  Reviewer is available!889-  Reviewer is unavailable!890Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)891for guidance on how you can benefit from the Reviewer Roulette, or use the892[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)893to find other available reviewers.894**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-community/gitlab/-/jobs/6625660180) that generated this comment.**896Not uploading cache ruby-gems-debian-bookworm-ruby-3.1 due to policy897Not uploading cache node-modules-debian-bookworm-test due to policy899Job succeeded 
