danger-review
Passed Started
by
@gerardo-navarro

Gerardo Navarro
1Running with gitlab-runner 16.11.0~pre.21.gaa21be2d (aa21be2d)2 on blue-6.shared-gitlab-org.runners-manager.gitlab.com/default SvV6b8rzM, system ID: s_5d6e1be0ca3a3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Dialing instance https://www.googleapis.com/compute/v1/projects/gitlab-r-saas-l-m-amd64-org-6/zones/us-east1-d/instances/blue-default-7359e9a21030c484...7Instance https://www.googleapis.com/compute/v1/projects/gitlab-r-saas-l-m-amd64-org-6/zones/us-east1-d/instances/blue-default-7359e9a21030c484 connected8Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...9Authenticating with credentials from job payload (GitLab Registry)10Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 ...11Using docker image sha256:4d97a6e6b48a500f28599f739761ccb23dc0b775b23fe71357e1f48df9074e52 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:56b23cca550b55e86db3c2471a1223d2b3a97ddff9a4bf6bd246dcef3ec64284 ...13Running on runner-svv6b8rzm-project-41372369-concurrent-15 via runners-manager-shared-gitlab-org-blue-6...15Fetching changes with git depth set to 20...16Initialized empty Git repository in /builds/gitlab-community/gitlab/.git/17Created fresh repository.18Checking out b4819a81 as detached HEAD (ref is 413641-441345-gerardo-navarro-protected-packages-and-containers-project-settings-ui-list-ui-add-count-icon)...19Skipping Git submodules setup20$ git remote set-url origin "${CI_REPOSITORY_URL}"22Checking cache for ruby-gems-debian-bookworm-ruby-3.1...23Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/41372369/ruby-gems-debian-bookworm-ruby-3.1 24Successfully extracted cache25Checking cache for node-modules-debian-bookworm-test...26Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/41372369/node-modules-debian-bookworm-test 27Successfully extracted cache29Using docker image sha256:4d97a6e6b48a500f28599f739761ccb23dc0b775b23fe71357e1f48df9074e52 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-120-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.20-rust-1.73-node-18.17-postgresql-14@sha256:56b23cca550b55e86db3c2471a1223d2b3a97ddff9a4bf6bd246dcef3ec64284 ...30$ source scripts/utils.sh31$ bundle_install_script "--with danger"709$ yarn_install_script764$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command766 * branch 413641-441345-gerardo-navarro-protected-packages-and-containers-project-settings-ui-list-ui-add-count-icon -> FETCH_HEAD767$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command768Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/analytics_instrumentation.rb769Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/bulk_database_actions.rb770Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/change_column_default.rb771Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/ci_templates.rb772Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/clickhouse.rb773Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/config_files.rb774Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/customer_success.rb775Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/database.rb776Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/database_dictionary.rb777Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/datateam.rb778Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/experiments.rb779Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/feature_flag.rb780Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/gitlab_schema_validation.rb781Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/ignored_model_columns.rb782Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/model_validations.rb783Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/multiversion.rb784Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/project_helper.rb785Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/required_stops.rb786Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/rubocop.rb787Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/saas_feature.rb788Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/sidekiq_args.rb789Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/sidekiq_queues.rb790Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/specs.rb791Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/stable_branch.rb792Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/todos.rb793Importing rule analytics_instrumentation at /builds/gitlab-community/gitlab/danger/analytics_instrumentation794Importing rule architecture at /builds/gitlab-community/gitlab/danger/architecture795Importing rule bulk_database_actions at /builds/gitlab-community/gitlab/danger/bulk_database_actions796Importing rule ce_ee_vue_templates at /builds/gitlab-community/gitlab/danger/ce_ee_vue_templates797Importing rule change_column_default at /builds/gitlab-community/gitlab/danger/change_column_default798Importing rule changelog at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changelog799Importing rule changes_size at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changes_size800Importing rule ci_config at /builds/gitlab-community/gitlab/danger/ci_config801Importing rule ci_tables at /builds/gitlab-community/gitlab/danger/ci_tables802Importing rule ci_templates at /builds/gitlab-community/gitlab/danger/ci_templates803Importing rule clickhouse at /builds/gitlab-community/gitlab/danger/clickhouse804Importing rule commit_messages at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commit_messages805Importing rule commits_counter at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commits_counter806Importing rule config_files at /builds/gitlab-community/gitlab/danger/config_files807Importing rule customer_success at /builds/gitlab-community/gitlab/danger/customer_success808Importing rule database at /builds/gitlab-community/gitlab/danger/database809Importing rule datateam at /builds/gitlab-community/gitlab/danger/datateam810Importing rule documentation at /builds/gitlab-community/gitlab/danger/documentation811Importing rule duplicate_yarn_dependencies at /builds/gitlab-community/gitlab/danger/duplicate_yarn_dependencies812Importing rule eslint at /builds/gitlab-community/gitlab/danger/eslint813Importing rule experiments at /builds/gitlab-community/gitlab/danger/experiments814Importing rule feature_flag at /builds/gitlab-community/gitlab/danger/feature_flag815Importing rule gitaly at /builds/gitlab-community/gitlab/danger/gitaly816Importing rule gitlab_schema_validation at /builds/gitlab-community/gitlab/danger/gitlab_schema_validation817Importing rule ignored_model_columns at /builds/gitlab-community/gitlab/danger/ignored_model_columns818Importing rule metadata at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/metadata819Importing rule model_validations at /builds/gitlab-community/gitlab/danger/model_validations820Importing rule multiversion at /builds/gitlab-community/gitlab/danger/multiversion821Importing rule pipeline at /builds/gitlab-community/gitlab/danger/pipeline822Importing rule prettier at /builds/gitlab-community/gitlab/danger/prettier823/builds/gitlab-community/gitlab/danger/saas_feature/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::SEE_DOC824/builds/gitlab-community/gitlab/danger/feature_flag/Dangerfile:3: warning: previous definition of SEE_DOC was here825/builds/gitlab-community/gitlab/danger/saas_feature/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT826/builds/gitlab-community/gitlab/danger/feature_flag/Dangerfile:9: warning: previous definition of SUGGEST_MR_COMMENT was here827Importing rule qa_selector at /builds/gitlab-community/gitlab/danger/qa_selector828Importing rule required_stops at /builds/gitlab-community/gitlab/danger/required_stops829Importing rule roulette at /builds/gitlab-community/gitlab/danger/roulette830Importing rule rubocop at /builds/gitlab-community/gitlab/danger/rubocop831Importing rule rubygems at /builds/gitlab-community/gitlab/danger/rubygems832Importing rule saas_feature at /builds/gitlab-community/gitlab/danger/saas_feature833Importing rule sidekiq_args at /builds/gitlab-community/gitlab/danger/sidekiq_args834Importing rule sidekiq_queues at /builds/gitlab-community/gitlab/danger/sidekiq_queues835Importing rule specialization_labels at /builds/gitlab-community/gitlab/danger/specialization_labels836Importing rule specs at /builds/gitlab-community/gitlab/danger/specs837Importing rule stable_branch_patch at /builds/gitlab-community/gitlab/danger/stable_branch_patch838Importing rule todos at /builds/gitlab-community/gitlab/danger/todos839Importing rule type_label at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/type_label840Importing rule utility_css at /builds/gitlab-community/gitlab/danger/utility_css841Importing rule vue_shared_documentation at /builds/gitlab-community/gitlab/danger/vue_shared_documentation842Importing rule z_add_labels at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_add_labels843Importing rule z_retry_link at /builds/gitlab-community/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_retry_link844Results:845Warnings:846- [ ] This merge request does not refer to an existing milestone.847- [ ] Labels missing: please ask a reviewer or maintainer to add ~"backend", ~"frontend", ~"documentation" to this merge request.848Messages:849- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.850Markdown:851## Documentation review852The following files require a review from a technical writer:853* `doc/api/graphql/reference/index.md` ([Link to current live version](https://docs.gitlab.com/ee/api/graphql/reference/))854The review does not need to block merging this merge request. See the:855- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.856- The [Technical Writer assigned](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments) for that stage and group.857- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.858## Multiversion compatibility859This merge request updates GraphQL backend and frontend code.860To prevent an incident, ensure the updated frontend code is backwards compatible.861For more information, see the [multiversion compatibility documentation](https://docs.gitlab.com/ee/development/graphql_guide/reviewing.html#multiversion-compatibility).862## Reviewer roulette863| Category | Reviewer | Maintainer |864| -------- | -------- | ---------- |865| ~"backend" | `@praba.m7n` [](https://gitlab.com/praba.m7n)  (UTC+2) | `@hustewart` [](https://gitlab.com/hustewart)  (UTC-4) |866| ~"frontend" | `@sheldonled` [](https://gitlab.com/sheldonled)  (UTC+1) | `@arfedoro` [](https://gitlab.com/arfedoro)  (UTC+2) |867**Please check reviewer's status!**868-  Reviewer is available!869-  Reviewer is unavailable!870Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)871for guidance on how you can benefit from the Reviewer Roulette, or use the872[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)873to find other available reviewers.874**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-community/gitlab/-/jobs/6550756204) that generated this comment.**876Not uploading cache ruby-gems-debian-bookworm-ruby-3.1 due to policy877Not uploading cache node-modules-debian-bookworm-test due to policy879Job succeeded