danger-review
Passed Started
by
@bymayanksingh

Mayank Singh
1Running with gitlab-runner 16.1.0~beta.59.g83c66823 (83c66823)2 on green-3.shared-gitlab-org.runners-manager.gitlab.com/default EuhiQzPR, system ID: s_360bc95445273 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:17ff485d60cad0e7a2cef114c588c387f0a02ea52778bdef56b31436edf609aa for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14@sha256:87a54d6d4c6d7bdd77d0700637df7c79a35b39235baf4c412cd1273ab94788c3 ...11Running on runner-euhiqzpr-project-41372369-concurrent-0 via runner-euhiqzpr-shared-gitlab-org-1688666948-1b8235a4...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-community/gitlab/.git/15Created fresh repository.16Checking out 7214ad23 as detached HEAD (ref is 414370-add-new-method-in-base-registry-for-value-transform)...17Skipping Git submodules setup18$ git remote set-url origin "${CI_REPOSITORY_URL}"20Checking cache for ruby-gems-debian-bullseye-ruby-3.0...21Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/41372369/ruby-gems-debian-bullseye-ruby-3.0 22Successfully extracted cache23Checking cache for node-modules-bullseye-test...24Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/41372369/node-modules-bullseye-test 25Successfully extracted cache27Using docker image sha256:17ff485d60cad0e7a2cef114c588c387f0a02ea52778bdef56b31436edf609aa for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-113-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-3.0.patched-golang-1.20-rust-1.65-node-18.16-postgresql-14@sha256:87a54d6d4c6d7bdd77d0700637df7c79a35b39235baf4c412cd1273ab94788c3 ...28$ source scripts/utils.sh29$ bundle_install_script "--with danger"695$ yarn_install_script739$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command740Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/analytics_instrumentation.rb741Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/config_files.rb742Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/customer_success.rb743Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/database.rb744Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/database_dictionary.rb745Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/datateam.rb746Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/experiments.rb747Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/feature_flag.rb748Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/multiversion.rb749Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/project_helper.rb750Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/sidekiq_args.rb751Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/sidekiq_queues.rb752Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/specs.rb753Importing plugin at /builds/gitlab-community/gitlab/danger/plugins/stable_branch.rb754Importing rule analytics_instrumentation at /builds/gitlab-community/gitlab/danger/analytics_instrumentation755Importing rule architecture at /builds/gitlab-community/gitlab/danger/architecture756Importing rule ce_ee_vue_templates at /builds/gitlab-community/gitlab/danger/ce_ee_vue_templates757Importing rule changelog at /builds/gitlab-community/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/changelog758Importing rule changes_size at /builds/gitlab-community/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/changes_size759Importing rule ci_config at /builds/gitlab-community/gitlab/danger/ci_config760Importing rule ci_tables at /builds/gitlab-community/gitlab/danger/ci_tables761Importing rule ci_templates at /builds/gitlab-community/gitlab/danger/ci_templates762Importing rule commit_messages at /builds/gitlab-community/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/commit_messages763/builds/gitlab-community/gitlab/tooling/danger/specs/feature_category_suggestion.rb:17: warning: Tooling::Danger::Suggestion#project_helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#project_helper764/builds/gitlab-community/gitlab/tooling/danger/specs/feature_category_suggestion.rb:18: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper765/builds/gitlab-community/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper766/builds/gitlab-community/gitlab/tooling/danger/suggestor.rb:34: warning: Tooling::Danger::Suggestion#helper at /usr/local/lib/ruby/3.0.0/forwardable.rb:157 forwarding to private method Danger::Specs#helper767Importing rule commits_counter at /builds/gitlab-community/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/commits_counter768Importing rule config_files at /builds/gitlab-community/gitlab/danger/config_files769Importing rule customer_success at /builds/gitlab-community/gitlab/danger/customer_success770Importing rule database at /builds/gitlab-community/gitlab/danger/database771Importing rule datateam at /builds/gitlab-community/gitlab/danger/datateam772Importing rule documentation at /builds/gitlab-community/gitlab/danger/documentation773Importing rule duplicate_yarn_dependencies at /builds/gitlab-community/gitlab/danger/duplicate_yarn_dependencies774Importing rule eslint at /builds/gitlab-community/gitlab/danger/eslint775Importing rule experiments at /builds/gitlab-community/gitlab/danger/experiments776Importing rule feature_flag at /builds/gitlab-community/gitlab/danger/feature_flag777Importing rule gitaly at /builds/gitlab-community/gitlab/danger/gitaly778Importing rule metadata at /builds/gitlab-community/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/metadata779Importing rule multiversion at /builds/gitlab-community/gitlab/danger/multiversion780Importing rule pajamas at /builds/gitlab-community/gitlab/danger/pajamas781Importing rule pipeline at /builds/gitlab-community/gitlab/danger/pipeline782Importing rule prettier at /builds/gitlab-community/gitlab/danger/prettier783Importing rule qa_selector at /builds/gitlab-community/gitlab/danger/qa_selector784Importing rule roulette at /builds/gitlab-community/gitlab/danger/roulette785Importing rule rubygems at /builds/gitlab-community/gitlab/danger/rubygems786Importing rule sidekiq_args at /builds/gitlab-community/gitlab/danger/sidekiq_args787Importing rule sidekiq_queues at /builds/gitlab-community/gitlab/danger/sidekiq_queues788Importing rule specialization_labels at /builds/gitlab-community/gitlab/danger/specialization_labels789Importing rule specs at /builds/gitlab-community/gitlab/danger/specs790Importing rule stable_branch_patch at /builds/gitlab-community/gitlab/danger/stable_branch_patch791Importing rule subtype_label at /builds/gitlab-community/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/subtype_label792Importing rule type_label at /builds/gitlab-community/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/type_label793Importing rule utility_css at /builds/gitlab-community/gitlab/danger/utility_css794Importing rule vue_shared_documentation at /builds/gitlab-community/gitlab/danger/vue_shared_documentation795Importing rule z_add_labels at /builds/gitlab-community/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/z_add_labels796Importing rule z_metadata at /builds/gitlab-community/gitlab/danger/z_metadata797Importing rule z_retry_link at /builds/gitlab-community/gitlab/vendor/ruby/3.0.0/gems/gitlab-dangerfiles-3.11.0/lib/danger/rules/z_retry_link798Results:799Markdown:800## Reviewer roulette801Changes that require review have been detected!802Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:803| Category | Reviewer | Maintainer |804| -------- | -------- | ---------- |805| ~"backend" | [Minahil Nichols](https://gitlab.com/minahilnichols)  (`@minahilnichols`) (UTC-4) | [Luke Duncalfe](https://gitlab.com/.luke)  (`@.luke`) (UTC+12) |806To spread load more evenly across eligible reviewers, Danger has picked a candidate for each807review slot, based on their timezone. Feel free to808[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)809if you think someone else would be better-suited810or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.811To read more on how to use the reviewer roulette, please take a look at the812[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)813and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).814Please consider assigning a reviewer or maintainer who is a815[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.816Once you've decided who will review this merge request, assign them as a reviewer!817Danger does not automatically notify them for you.818**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-community/gitlab/-/jobs/4610006199) that generated this comment.**820Not uploading cache ruby-gems-debian-bullseye-ruby-3.0 due to policy821Not uploading cache node-modules-bullseye-test due to policy823Job succeeded