Add additional details to Reviewer responsibilities
Why is this change being made?
Some guidance for Reviewers specific to some questions brought up today during our Team call, regarding how to get maintainer feedback on specific review items, before having approved and handed off to a maintainer.
Author Checklist
-
Provided a concise title for the MR -
Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what -
Assign this change to the correct DRI - If the DRI for the page/s being updated isn’t immediately clear, then assign it to your manager.
- If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
- If the changes relate to any part of the project other than updates to content and/or data files please make sure to ping
@gl-static-site-editor
in a comment for a review and merge. For example changes to.gitlab-ci.yml
, JavaScript/CSS/Ruby code or the layout files.
For help with failing pipelines reach out in #mr-buddies in Slack
Edited by DJ Mountney