Skip to content

Add Salary Calculator

Clement Ho requested to merge 831-make-a-salary-calculator into master

This MR adds a salary calculator to the jobs page. During this first release, it will only be available in the /jobs/developer/ but the system that has been setup should easily enable us to add the calculator to other job pages by providing a benchmark salary on jobs.yml.

Tasks Remaining

  1. Add UI
  2. Setup source/salary/*.json to mirror/dynamically get data from data/*.json (Need guidance)
  3. Figure out a way so that we don't have to use extra-js on each job markdown file (Need guidance)
  4. Convert json data files to yml (Not too sure, need guidance)
  5. Fix weird UI bug where there's a space between the <a> and the .
  6. Link how our calculator works
  7. Add contract types link @ernstvn
  8. Fix css lint issues

Task 2: Setup source/salary/*.json to mirror/dynamically get data from data/*.json (Need guidance)

Definitely want to do this. Just not sure how to do it with middleman/ruby/haml. /cc @smcgivern

Task 3: Figure out a way so that we don't have to use extra-js on each job markdown file (Need guidance)

It would be ideal to include the salary-calculator.js as part of the salary_calculator.html.haml so that we do not need to reference it in each job markdown file. I need some ruby guidance. /cc @smcgivern

Task 4: Convert json data files to yml (Not too sure, need guidance)

All the data files currently use yml. I think it makes sense to make the json data a yml file in /data and have it generate its corresponding json file in /source. Any inputs/comments about this? /cc @smcgivern

Closes #831 (closed)

Closes https://gitlab.com/gitlab-com/peopleops/issues/115

Merge request reports