Skip to content

Remove absolute links in handbook/engineering/ md files

Miguel Rincon requested to merge remove-some-absolute-links into master

Currently, our CI job enforce_relative_links finds absolute links in the handbook but it is allowed to fail (allow_failure: true), so many links are left absolute.

This MR aims to reduce the number of absolute links in the source/handbook/engineering/ .md files.

I ran the command locally:

$ ag --filename --numbers --break --nogroup --depth -1 --stats --path-to-ignore ./.relative_links_ignore '(?<!`|")https?://about.gitlab.com(?!`|\S*")' ./source && rc="$?" || rc="$?"

Before the changes:

1625 matches
446 files contained matches
4023 files searched
51711580 bytes searched
0.110980 seconds

After:

1550 matches
420 files contained matches
4023 files searched
51709780 bytes searched
0.108229 seconds

Why only handbook/engineering files? I wanted to make a general change to the handbook but it would be too many links to check manually, and it is still possible that there are some special cases I didn't consider. So I decided to only change one section of the handbook that I can check myself.

Edited by Miguel Rincon

Merge request reports