Skip to content

Add capability for some roles to have no levels

Tommy Morgan requested to merge make-comp-levels-optional into master

The comp calculator for Engineering Management right now is confusing because you have to always set the level to 1.4 (people manager). In reality, the role doesn't have levels, but the option is there. So it's confusing UX and has other implications for the data where the benchmark assumes a 1.4 modifier, etc.

This MR adds the ability for an entry in data/roles.yml to have a levels: false flag that will disable the level field in the calculator for that role, like this:

image

For any role that doesn't have levels: false set, the calculator will continue to function as it has to date.

I also went ahead and added this flag to the Engineering Management role, and multiplied the benchmark by 1.4 so that all of our data remains the same.

@jkalimon does this look right to you? If so, will you please assign to whoever should approve and merge?

Side note: this also sets us up for something else that I think would be a good idea, which is the ability to define levels and their multipliers in the roles.yml data, rather than having them hard-coded in the calculator. But that is something we can leave for a later iteration.

/cc @dhavens @edjdev

Merge request reports