Skip to content

Clarify code review flow for Auth group

Jessie Young requested to merge jy-review-auth into master

Why is this change being made?

  • There was some ambiguity before about whether the Auth team member review counts as a review or if our team's MRs should have an additional review before a maintainer review.
  • Danger comments also make this confusing because auth reviews are in a different category from backend. Example: gitlab-org/gitlab!102959 (comment 1159925213)

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Merge request reports