Skip to content

Change expected SLO with disabled feature flags

Dominic Couture requested to merge dcouture-feature-flag-slo into master

Why is this change being made?

For S1 and S2 the current language is

Within X days or before the feature flag is enabled, whichever comes first

and I think that should be changed simply to "Before the feature flag is enabled". My reasons are the following:

  1. We caught the bug before the feature is made available so it should be fixed before the feature is enabled even if it's enabled before the end of the regular SLO (and the old wording already provided that)
  2. If we stop working on the feature and it won't be enabled for months (years?) I think we should prioritize work on fixing security issues for features that are live even if the severity is lower

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Dominic Couture

Merge request reports