GraphQL code reviews are taking longer due to lack of GraphQL Expertise (Brainstorming Issue)
Background
According to our handbook we are encouraging GraphQL First
When adding new functionality, we should use GraphQL where possible on the backend and the frontend. We have a long-term goal to use GraphQL everywhere because it lets us increase development speed, reduces dependencies between frontend and backend engineers, and gives us a single source of truth for application data.
Problem
There are many Backend and Frontend Engineers who are not experienced enough in GraphQL to perform code reviews. Consequently, these reviews can take longer than 24 hours to actually be picked up. Here is the scenario we are running into:
- Day 1: Engineer submits an MR to a Code Reviewer which includes GraphQL
- Day 2: The Code Reviewer responds that they don't know GraphQL and asks the Engineer to find another reviewer
- Day 3: The Engineer looks for a GraphQL expert to review the code and assigns the review to that person.
This could also happen again at the Maintainer level.
Purpose
The purpose of this issue is to brainstorm and discuss solutions to the Problem.