Trainee Frontend Maintainer: Mark Florian
Basic setup
-
Read the code review page in the handbook and the code review guidelines. -
Understand how to become a maintainer and add yourself as a trainee maintainer on the team page.
TODO
-
@markrian Add MRs I've authored with little/no maintainer feedback
Working towards becoming a maintainer
There is no checklist here, only guidelines. Remember that there is no specific timeline on this.
It is up to you to ensure that you are getting enough MRs to review, and of varied types. All engineers are reviewers, so you should already be receiving regular reviews from Reviewer Roulette. You could also seek out more reviews from your team, or #frontend Slack channels.
Your reviews should aim to cover maintainer responsibilities as well as reviewer responsibilities. Your approval means you think it is ready to merge.
We recommend to act as a coach in a big deliverable that requires following the planning step as part of the trainee program.
After each MR is merged or closed, add a discussion to this issue using this template:
### (Merge request title): (Merge request URL)
During review:
- (List anything of note, or a quick summary. "I suggested/identified/noted...")
Post-review:
- (List anything of note, or a quick summary. "I missed..." or "Merged as-is")
(Maintainer who reviewed this merge request) Please add feedback, and compare
this review to the average maintainer review.
Note: Do not include reviews of security MRs because review feedback might reveal security issue details.
When you're ready to make it official
When reviews have accumulated, and recent reviews consistently fulfill maintainer responsibilities, any maintainer can take the next step. The trainee should also feel free to discuss their progress with their manager or any maintainer at any time.
-
Create a merge request for team page proposing yourself as a maintainer. !38408 (merged) -
Create a merge request for CODEOWNERS, adding yourself accordingly, and ask a maintainer to review it.It seems this is no longer relevant, as CODEOWNERS refers to the@gitlab-org/maintainers/frontend
. The question then is, how do I get added to that group? -
Keep reviewing, start merging 🤘