Skip to content
Snippets Groups Projects

Release post - GitLab 12.0

Merged Jeremy Watson (ex-GitLab) requested to merge release-12-0 into master
All threads resolved!
4 files
+ 26
13
Compare changes
  • Side-by-side
  • Inline
Files
4
@@ -447,14 +447,14 @@ These templates should be used during the onboarding process and throughout the
@@ -447,14 +447,14 @@ These templates should be used during the onboarding process and throughout the
* All new access or permissioning change requests require a [New Access Request](https://gitlab.com/gitlab-com/access-requests/issues/new?issuable_template=New%20Access%20Request).
* All new access or permissioning change requests require a [New Access Request](https://gitlab.com/gitlab-com/access-requests/issues/new?issuable_template=New%20Access%20Request).
* All access requests must be approved by the team member's manager with the exception of:
* All access requests must be approved by the team member's manager with the exception of:
- ARs for G-Suite email distribution lists for internal GitLab team members
- ARs for G-Suite email distribution lists for internal GitLab team members
- ARs for Slack groups for internal GitLab team members
- ARs for Slack groups for internal GitLab team members
Please note that ARs for access to internal systems for "external to GitLab individuals" (eg. customers, prospects) require managerial approval. This includes access to G-Suite security groups also require managerial approval.
Please note that ARs for access to internal systems for "external to GitLab individuals" (eg. customers, prospects) require managerial approval. This includes access to G-Suite security groups also require managerial approval.
* Requests for access to Infrastructure assets (servers and databases) require a second layer of approval from Infrastructure Management.
* Requests for access to Infrastructure assets (servers and databases) require a second layer of approval from Infrastructure Management.
* All requests for new service accounts require a [New Service Account Request](https://gitlab.com/gitlab-com/access-requests/issues/new?issuable_template=New%20Service%20Account%20Request)
* All requests for new service accounts require a [New Service Account Request](https://gitlab.com/gitlab-com/access-requests/issues/new?issuable_template=New%20Service%20Account%20Request)
* All requests for new service accounts must be approved by a member of Infrastructure Management.
* All requests for new service accounts must be approved by a member of Infrastructure Management.
@@ -475,7 +475,7 @@ These templates should be used during the onboarding process and throughout the
@@ -475,7 +475,7 @@ These templates should be used during the onboarding process and throughout the
### Access Requests and Onboarding
### Access Requests and Onboarding
During the onboarding process, the manager should determine which email and slack groups the new team member should be added to. Also determine if new team member will need access to the `dev` server, which is used by engineers to prepare fixes for security issues and also allows for access to version.gitlab.com and license.gitlab.com. If so, request the creation of a [new dev.GitLab.org account](https://dev.gitlab.org/admin/users/new) *with the same username the team member has on gitlab.com* and an invitation to the [gitlab group](https://dev.gitlab.org/groups/gitlab/group_members) as a Developer. Fill out one [access request](https://gitlab.com/gitlab-com/access-requests/issues) for both the groups and Dev account if needed.
During the onboarding process, the manager should determine which email and slack groups the new team member should be added to. Also determine if new team member will need access to the `dev` server, which is used by engineers to prepare fixes for security issues and also allows for access to version.gitlab.com and license.gitlab.com. If so, request the creation of a [new dev.GitLab.org account](https://dev.gitlab.org/admin/users/new) *with the same username the team member has on gitlab.com* and an invitation to the [gitlab group](https://dev.gitlab.org/groups/gitlab/group_members) as a Developer. Fill out one [access request](https://gitlab.com/gitlab-com/access-requests/issues) for both the groups and Dev account if needed.
### Deprovisioning
### Deprovisioning
@@ -488,7 +488,7 @@ During the onboarding process, the manager should determine which email and slac
@@ -488,7 +488,7 @@ During the onboarding process, the manager should determine which email and slac
### Access Reviews
### Access Reviews
* Access reviews will be formally documented using the [Access Reviews](https://gitlab.com/gitlab-com/access-requests/issues/new?issuable_template=Access%20Review) template.
* Access reviews will be formally documented using the [Access Reviews](https://gitlab.com/gitlab-com/access-requests/issues/new?issuable_template=Access%20Review) template.
* As part of an access review, existing access may be modified or revoked. New access (not modification of existing access) requires the submission of a [New Access Request](https://gitlab.com/gitlab-com/access-requests/issues/new?issuable_template=New%20Access%20Request).
* As part of an access review, existing access may be modified or revoked. New access (not modification of existing access) requires the submission of a [New Access Request](https://gitlab.com/gitlab-com/access-requests/issues/new?issuable_template=New%20Access%20Request).
### Access Control Process Exceptions
### Access Control Process Exceptions
@@ -496,10 +496,10 @@ During the onboarding process, the manager should determine which email and slac
@@ -496,10 +496,10 @@ During the onboarding process, the manager should determine which email and slac
* An access request is not required for Google Drive folders or files.
* An access request is not required for Google Drive folders or files.
* Managerial approval is not required when requesting access to:
* Managerial approval is not required when requesting access to:
- ARs for G-Suite email distribution lists for internal GitLab team members
- ARs for G-Suite email distribution lists for internal GitLab team members
- ARs for Slack groups for internal GitLab team members
- ARs for Slack groups for internal GitLab team members
* Bulk requests can be submitted for the following three types of requests:
* Bulk requests can be submitted for the following three types of requests:
- Email aliases/forwarding in GSuite
- Email aliases/forwarding in GSuite
@@ -529,7 +529,7 @@ During the onboarding process, the manager should determine which email and slac
@@ -529,7 +529,7 @@ During the onboarding process, the manager should determine which email and slac
| gitlab.com | SRE | Admin - admin account-username |
| gitlab.com | SRE | Admin - admin account-username |
| ops.gitlab.net | SRE | added w/ production group from chef users databag|
| ops.gitlab.net | SRE | added w/ production group from chef users databag|
| staging.gitlab.com | SRE | add Admin role to regular account |
| staging.gitlab.com | SRE | add Admin role to regular account |
| GCP | SRE | Folder Admin/Infra. |
| GCP | SRE | Folder Admin/Infra. |
| Chef | SRE | Admin |
| Chef | SRE | Admin |
| Pager Duty | SRE | Admin |
| Pager Duty | SRE | Admin |
| Status.io | SRE | Admin |
| Status.io | SRE | Admin |
@@ -806,7 +806,7 @@ Team members remain responsible for their own assigned reports.
@@ -806,7 +806,7 @@ Team members remain responsible for their own assigned reports.
- Import the report into a GitLab issue using `/h1import *report_id* [ce/ee] [Sx] [Px]` in Slack
- Import the report into a GitLab issue using `/h1import *report_id* [ce/ee] [Sx] [Px]` in Slack
- Assign the appropriate [Severity and Priority](#severity-and-priority-labels-on-security-issues).
- Assign the appropriate [Severity and Priority](#severity-and-priority-labels-on-security-issues).
- Assign the appropriate [Due Date](#due-date-on-security-issues)
- Assign the appropriate [Due Date](#due-date-on-security-issues)
- @ mention product manager of appropriate teams for scheduling and/or the engineering managers if additional engineering feedback is required to complete the triage, based on the [current organization chart](/company/team/org-chart).
- @ mention product manager of appropriate teams for scheduling and/or the engineering managers if additional engineering feedback is required to complete the triage, based on the [product categories page](https://about.gitlab.com/handbook/product/categories/)
- As applicable, notify relevant team members via the issue, chat, and email, depending on the chosen security level.
- As applicable, notify relevant team members via the issue, chat, and email, depending on the chosen security level.
- Change the state of the report to "Triaged" in HackerOne and include a link to the issue as the reference.
- Change the state of the report to "Triaged" in HackerOne and include a link to the issue as the reference.
- Fill in the comment using the `00 - Triaged` Common
- Fill in the comment using the `00 - Triaged` Common
@@ -832,6 +832,14 @@ Team members remain responsible for their own assigned reports.
@@ -832,6 +832,14 @@ Team members remain responsible for their own assigned reports.
as the template for the bounty award if approved.
as the template for the bounty award if approved.
- In any case, no report should go "stale" where updates are not provided within the last month.
- In any case, no report should go "stale" where updates are not provided within the last month.
 
#### Critical Vulnerabilities
 
 
When critical vulnerabilities are identified, it is necessary to quickly get the attention of the appropriate engineering team and the security operations team
 
in order to fully determine impact to `gitlab.com` and to self-managed customers. When a vulnerability is determined to be P1/S1, do the following after following
 
the steps above:
 
- [Engage the security oncall](#engaging-the-security-on-call) with a link to the issue.
 
- Post the link to the issue in the appropriate engineering team's Slack channel, requesting review.
 
#### If a Report is Unclear
#### If a Report is Unclear
If a report is unclear, or the reviewer has any questions about the validity of the finding or how it can be exploited, now is the time to ask. Move the report to the "Needs More Info" state until the researcher has provided all the information necessary to determine the validity and impact of the finding. Use your best judgement to determine whether it makes sense to open a confidential issue anyway, noting in it that you are seeking more information from the reporter. When in doubt, err on the side of opening the issue.
If a report is unclear, or the reviewer has any questions about the validity of the finding or how it can be exploited, now is the time to ask. Move the report to the "Needs More Info" state until the researcher has provided all the information necessary to determine the validity and impact of the finding. Use your best judgement to determine whether it makes sense to open a confidential issue anyway, noting in it that you are seeking more information from the reporter. When in doubt, err on the side of opening the issue.
Loading