Skip to content

KR: Migrate 200 HAML component instances to Pajamas => 99%

In Dev we want to migrate at least 20 200 HAML instances to new Pajama components.

Overall Epic that is collecting the overall work - gitlab-org&3963 (closed)

Done so far 199 migrations

Updated Table on 2020-10-06 from the epic

Component Epic Tracked Completed % Notes
Alerts gitlab-org&4070 (closed) 46/58 79.3% This has been largely driven by community contributions
Pagination None created 100% There weren't any examples of this. Easy win
Buttons gitlab-org&4001 (closed) 38/192 19.7% I'm making a push to get these tackled by the community. I'm also looking into the possibility of using the "find, replace, apologise for the mess" approach
Modals gitlab-org&4386 0/25 0% We're going to have to tackle theese on a case-by-case basis
Dropdowns gitlab-org&4549 0/68 0% We still need to work out how to tackle these. Discussion
Tooltips gitlab-org&4383 (closed) 107/108 99% The epic was created after work started so the number in the epic is only for the remaning quarter of the issues
Popovers gitlab-org&4409 (closed) 8/8 100%
Tabs gitlab-org&3983 0/52 0% We're tracking these, but the path is still al little unclear
- - - - - -
Total 📈 199/511 38.9% https://www.youtube.com/watch?v=vjD3EVC1-zU

Retrospective

Good

  • We got a lot of community involvement on this KR
  • We made a sizeable dent in the amount of bootstrap uses across the codebase
  • Popovers, tooltips, and pagination were (almost) completely removed/replaced

Bad

  • Bulk updating buttons was troublesome and caused some visual regressions
  • There was 0 movement on some of the harder migrations like dropdowns and modals
  • The scoring of this KR is difficult due to the goals being too low in most cases

Try

  • A better path for bulk updating smaller changes
  • Being more ambitious with our KR targets
  • Focusing attention on a couple of the larger components that were missed this time around
Edited by Sam Beckham