Pilot new proposed code review process
This pilot is to measure the impact of introducing domain experts in the code review process. For more information read the original issue here: #4517
Objectives
- Improved efficiency with regards to:
- Time it takes for reviewers and maintainers to respond to the MR
- Reduction in overall Mean Time To Merge (MTTM)
- Improved quality with regards to the solution being implemented
- Consistency with domain architecture
- Performant and secure solutions
Implementation
- The trial will run the full duration of milestone 12.9 (23 Feb - 20 Mar)
- Note: overlaps with travel to contribute.
- The trial will be limited to 2-3 groups/stages
- For the duration of the trial the team members will ignore the Reviewer Roulette recommendations and follow the following rules:
- For a first review, assign it to a team member in their group
- For maintainer review, give preference to one of the maintainers identified for the trial (who will have domain expertise for the identified group/stage), but if they are OOO or at capacity assign it to any other relevant maintainer.
Measuring impact
NOTE: While we will try to be as scientific in our observations and measurements, it should be noted that we don't have a controlled environment. The primary measurement we will rely on is an improved sentiment and perceived improvement in speed and and quality from those involved in the pilot.
- To measure whether the trial was successful in meeting its objectives we will look at:
- We will ask the MR authors, reviewers and maintainers to complete a survey relating to the efficiency and quality objectives
- We will look at the data relating to
- MTTM for the duration of the trial (milestone 12.9) compared to previous milestones
- Reviewer and maintainer response time
- An async retrospective issue will be opened specifically to discuss the trial with all those involved. The issue will be opened at the beginning of milestone 12.9 so that team members can add to it as we progress and will stay open for two week after the milestone closes to accommodate the overlap with Contribute.
Preferred maintainers
Maintainer | Create:Editor | Create:Knowledge | Manage:Analytics | Manage:Access |
---|---|---|---|---|
@dzaporozhets |
||||
@stanhu |
||||
@dbalexandre |
||||
@reprazent |
||||
@ifarkas |
Communication
Please note that in addition to this issue we are using the #domain-experts-pilot
Slack channel for communication
Edited by Nick Thomas