Review maintainer duties/requirements and implement proposed changes
Background
This issue is related to the Update expected behaviors and responsibilities for Engineers and Maintainers epic which is a part of the larger Maintainership Working Group Epic.
Problems to solve:
- Maintainer duties may not align with perception
- Maintainer duties may be too much / too little
Purpose
The purpose of this issue is to:
-
Review current maintainer duties and requirements. For example -
Gather and discuss ideas to update duties and requirements. -
Implement agreed upon changes. -
Gather any feedback up to 2022-09-02, and implement agreed upon changes -
Communicate changes following https://about.gitlab.com/company/team/structure/working-groups/maintainership/#communicating-changes -
Make a refresher training package for reviewers/maintainers walking though the changes - [-] A recording of a maintainer reviewing an MR
- [-] A Google Slides presentation with FAQs like "how can I feel confident merging this when it is not an area I'm experienced with?"
-
doc/development/code_review.md
Changelog for List of MRs, or potential MRs
-
Clarify responsibility for splitting large MR gitlab-org/gitlab!93992 (merged) -
Maintainers as quality DRIs gitlab-org/gitlab!93691 (merged) -
Reviewers should review specifics, rather than maintainers gitlab-org/gitlab!93994 (merged) -
Do check out the branch and perform a smoke testing of the changes; pulling and testing the code themselves. gitlab-org/gitlab!95420 (merged) -
Update how to find domain experts: gitlab-org/gitlab!93994 (comment 1050217686) => gitlab-org/gitlab!95421 (merged) -
Remove requirement to check Security Widget => gitlab-org/gitlab!95542 (merged), gitlab-org/gitlab#370891 - [-]
Update who is domain experts, encourage ; gitlab-org/gitlab!93994 (comment 1051539817) TBC
https://about.gitlab.com/handbook/engineering/workflow/code-review/
Changelog for-
Handbook: Update Maintainer misconceptions !109435 (merged)
Where can I find out more about the efforts of the Working Group?
To learn more about the latest topics being discussed by the Maintainership Working Group, please refer to any of the items below:
Edited by Thong Kuah