Review maintainer duties/requirements and implement proposed changes

Background

This issue is related to the Update expected behaviors and responsibilities for Engineers and Maintainers epic which is a part of the larger Maintainership Working Group Epic.

Problems to solve:

  1. Maintainer duties may not align with perception
  2. Maintainer duties may be too much / too little

Purpose

The purpose of this issue is to:

  1. Review current maintainer duties and requirements. For example
    1. GitLab - https://docs.gitlab.com/ee/development/code_review.html#the-responsibility-of-the-reviewer, and https://docs.gitlab.com/ee/development/code_review.html#the-responsibility-of-the-maintainer
    2. General - https://about.gitlab.com/handbook/engineering/workflow/code-review/
  2. Gather and discuss ideas to update duties and requirements.
  3. Implement agreed upon changes.
  4. Gather any feedback up to 2022-09-02, and implement agreed upon changes
  5. Communicate changes following https://about.gitlab.com/company/team/structure/working-groups/maintainership/#communicating-changes
    1. Make a refresher training package for reviewers/maintainers walking though the changes
    2. [-] A recording of a maintainer reviewing an MR
    3. [-] A Google Slides presentation with FAQs like "how can I feel confident merging this when it is not an area I'm experienced with?"

Changelog for doc/development/code_review.md

List of MRs, or potential MRs

Changelog for https://about.gitlab.com/handbook/engineering/workflow/code-review/

Where can I find out more about the efforts of the Working Group?

To learn more about the latest topics being discussed by the Maintainership Working Group, please refer to any of the items below:

Edited by Thong Kuah