Refine Definition of Done to be MR merge time and Production Done
The definition of done needs to be broken out about MR merge expectations vs. getting code working on production expectations.
https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#definition-of-done
MR: gitlab-org/gitlab!70528 (merged)
Tasks
-
Review recently revised MR checklist for potential additions to definition of done: https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist -
Review revised blast radius reduction for potential additions to definition of done: !90263 (merged) -
Add reference to rollout plan (it is mentioned in the MR merge section but not in the definition of done -
Add reference to review apps and manual testing
Communication plan
-
Announce in Slack channels -
VP Development meeting -
Add to #EWIR
Edited by Wayne Haber