Trainee Maintainer (CI/CD Templates) - Marcel Amirault
Basic setup
-
Read the code review page in the handbook and the code review guidelines. -
Understand how to become a maintainer -
Read over our Development Guide for GitLab CI/CD Templates -
Create a merge request updating your team member entry adding yourself as a trainee maintainer.
Working towards becoming a maintainer
There is no checklist here, only guidelines. Remember that there is no specific timeline on this.
Your reviews should aim to cover maintainer responsibilities as well as reviewer responsibilities. Your approval means you think it is ready to merge.
After each MR is merged or closed, add a discussion to this issue using this template:
### (Merge request title): (Merge request URL)
During review:
- (List anything of note, or a quick summary. "I suggested/identified/noted...")
Post-review:
- (List anything of note, or a quick summary. "I missed..." or "Merged as-is")
(Maintainer who reviewed this merge request) Please add feedback, and compare
this review to the average maintainer review.
Tip: There are tools available to assist with this task.
List of the MRs I worked on:
- gitlab-org/gitlab!60308 (comment 561073394)
- gitlab-org/gitlab!64330 (comment 604513209)
- gitlab-org/gitlab!64050 (comment 601112945) (self-merged as it was code comment changes only)
- gitlab-org/gitlab!63964 (comment 600465718) (self-merged as it was broken, and the fix was trivially correct)
- gitlab-org/gitlab!63897 (comment 601111385)
- gitlab-org/gitlab!63822 (comment 600116859) (fix the rules as we decided to not use MR pipelines in 14.0)
-
gitlab-org/gitlab!55949 (comment 525240556) (suggested changing hardcoded
master
andmain
to useCI_DEFAULT_BRANCH
. - gitlab-org/gitlab!58649 (comment 545710290) (Suggested expanding the "Hello world" template to show a few more things, but they decided to keep it simple).
-
gitlab-org/gitlab!63382 (comment 606283962) (Suggested making the updated
rules
multi-line to match the other rules). - gitlab-org/gitlab!66910 (comment 641437978) (I missed that this MR didn't have the changelog trailer)
- gitlab-org/gitlab!63351 (diffs, comment 596297717)
- gitlab-org/gitlab!57919 (comment 542683106): Our first partner template, which spawned all the discussion about improving our template process. I also significantly updated the contribution docs/process as a result: gitlab-org/gitlab!56843 (merged)
- gitlab-org/gitlab!60811 (comment 568409792)
- gitlab-org/gitlab!61283 (comment 584144552)
- gitlab-org/gitlab!61412 (comment 573288002)
- gitlab-org/gitlab!61814 (comment 576551012)
- gitlab-org/gitlab!61833 (comment 584117275)
- gitlab-org/gitlab!62161 (comment 581568279)
- gitlab-org/gitlab!62252 (comment 583225688) (Suggested adding a note to keep track of the move, but missed that we could split the changes into two MRs to be more MVC)
- gitlab-org/gitlab!62358 (comment 583218185) (How Semver was being used there was not clear to me, so I asked about it and now I understand)
- gitlab-org/gitlab!62407 (comment 584142477)
- gitlab-org/gitlab!62597 (comment 598927655)
- gitlab-org/gitlab!62727 (comment 587304879) (I had a few follow-up questions that Matija agreed with)
- gitlab-org/gitlab!62810 (comment 589501328) (My suggestion spawned a lot of discussion about the best course of action, and in the end my idea was definitely not the best one, and we went with something better)
- gitlab-org/gitlab!63547 (comment 596295437) (I missed that the new image was not in the container registry, but Matija caught it and they added it in).
- gitlab-org/gitlab!63608 (comment 596301415) (Self-merged as it was a code comment fix only)
When you're ready to make it official
When reviews have accumulated, and recent reviews consistently fulfill maintainer responsibilities, any maintainer can take the next step. The trainee should also feel free to discuss their progress with their manager or any maintainer at any time.
-
Create a merge request updating your team member entry proposing yourself as a maintainer. Ask the existing maintainers for approval by pinging @gitlab-org/maintainers/cicd-templates
in your MR. -
Create a merge request for CODEOWNERS, adding yourself accordingly, and ask a maintainer to review it. -
Keep reviewing, start merging 🤘 -
Keep reviewing, and helping with merge requests! 🎉 -
Important Read: If you are not currently a backend or frontend maintainer, please assign the merge requests to a maintainer who can merge on your behalf, specifying that it has already been approved by a CI/CD templates maintainer.
Edited by Marcel Amirault