Commit c59eaa2c authored by emilie's avatar emilie

make flag not public and edit logic

parent 4ab366e3
Pipeline #103850282 passed with stages
in 13 minutes and 17 seconds
......@@ -518,7 +518,7 @@
base_path: /handbook/engineering/infrastructure/performance-indicators/
definition: This metric reflects an estimate of the dollar cost necessary to support one user in GitLab.com. It is an important metric because it allows us to estimate infrastructure costs as our user base grows. Infrastructure Hosting Cost comes from Netsuite; it is a sum of actual amounts with the unique account name '5026 - Hosting Services COGS' or '6026 - Hosting Services'. This cost is divided by <a href="/handbook/product/metrics/#monthly-active-user-mau">MAU</a>
target: 1.5
public: false
not_public: true
org: Infrastructure Department
is_key: true
urls:
......
......@@ -122,7 +122,11 @@ module CustomHelpers
reasons.push("Needs a definition") unless performance_indicator.definition
reasons.push("Needs a target") unless performance_indicator.target
reasons.push("Needs periscope data") unless performance_indicator.periscope_data
if performance_indicator.not_public && !performance_indicator.url
reasons.push("Needs a url")
elsif !performance_indicator.not_public && !performance_indicator.periscope_data
reasons.push("Needs periscope data")
end
reasons
end
......
......@@ -6,8 +6,8 @@
<p><b>Target:</b> <%= performance_indicator.target %></p>
<% end %>
<% if performance_indicator.public %>
<p><b>Can be public:</b> <%= performance_indicator.public %></p>
<% if performance_indicator.not_public %>
<p><b>This KPI cannot be public.</b> </p>
<% end %>
<% if performance_indicator.urls %>
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment