flip boolean logic

data/performance_indicators.yml

@@ -324,7 +324,7 @@
     level: 2
     reasons:
       - Single code base has slowed this metric. OKR to continue to see improvement here 'https://gitlab.com/gitlab-com/www-gitlab-com/issues/5648'
-      - Last 4 months have seen MR rate steadily increase.  December would have done better except for holiday break.  
+      - Last 4 months have seen MR rate steadily increase.  December would have done better except for holiday break.
       - "We need to continue to push for iterative behaviors and incremental MRs that smaller and faster"
   periscope_data:
     chart: 6946736
@@ -504,7 +504,7 @@
   base_path: /handbook/engineering/infrastructure/performance-indicators/
   definition: This metric reflects an estimate of the dollar cost necessary to support one user in GitLab.com. It is an important metric because it allows us to estimate infrastructure costs as our user base grows. Infrastructure Hosting Cost comes from Netsuite; it is a sum of actual amounts with the unique account name '5026 - Hosting Services COGS' or '6026 - Hosting Services'. This cost is divided by <a href="/handbook/product/metrics/#monthly-active-user-mau">MAU</a>
   target: 1.5
-  not_public: true
+  public: false
   org: Infrastructure Department
   is_key: true
   urls:

helpers/custom_helpers.rb

@@ -112,7 +112,7 @@ module CustomHelpers
 
     level += 1 if performance_indicator.definition
     level += 1 if performance_indicator.target
-    if performance_indicator.not_public == true && performance_indicator.urls
+    if performance_indicator.public == false && performance_indicator.urls
       level += 1
     elsif performance_indicator.periscope_data
       level += 1
@@ -126,9 +126,9 @@ module CustomHelpers
 
     reasons.push("Needs a definition") unless performance_indicator.definition
     reasons.push("Needs a target") unless performance_indicator.target
-    if performance_indicator.not_public == true && !performance_indicator.urls
+    if performance_indicator.public == false && !performance_indicator.urls
       reasons.push("Needs a url")
-    elsif performance_indicator.not_public != true && !performance_indicator.periscope_data
+    elsif performance_indicator.public == true && !performance_indicator.periscope_data
       reasons.push("Needs Sisense Embed Info")
     end
 

source/includes/_performance_indicator.erb

@@ -6,7 +6,7 @@
   <p><b>Target:</b> <%= performance_indicator.target %></p>
 <% end %>
 
-<% if performance_indicator.not_public == true %>
+<% if performance_indicator.public == false %>
   <p><b>This KPI cannot be public.</b> </p>
 <% end %>