Follow-up from "Gem Update / Lint Update"
The following discussion from !66 (merged) should be addressed:
-
@rvzon started a discussion: (+3 comments) Why is
activesupport
specified? Since it was already included?
Davin Walker Previously, slack-ruby-client (0.13.1) included activesupport as a dependency. Updated slack-ruby-client (0.15.1) does not.
slack-ruby-client (0.15.1)
faraday (>= 1.0)
faraday_middleware
gli
hashie
websocket-driver
slack-ruby-client (0.13.1)
activesupport
faraday (>= 0.9)
The slack-ruby-bot still requires active support`, it is an open known issue.
The immediate ramification is that the tests fail:
Failure/Error: require 'slack-ruby-bot/rspec'
LoadError:
cannot load such file -- active_support
Ronald van Zon So in the future, it's possible that slack-ruby-bot will fix this. I recommend making a note above it why we added this gem manually.
Davin Walker Yup, it's not a particularly long-standing issue so might be merged soon.
I'm mixed on the explicit comment. We don't have any other notes for the other gems, and activesupport is one of the most common gems, that we could take advantage of (say in another open MR ;) )
related to MR !66 (merged)