Skip to content

Next

runbooks
runbooks
Commit 271ee97f authored by Andrew Newdigate's avatar Andrew Newdigate
Browse files
Options

Merge branch 'remove-normal-range-for-non-normal-metrics' into 'master' 

Remove normal range from non-normal metrics

See merge request !1116
parents 41576e3c a4127e57
Show whitespace changes
Inline Side-by-side
Showing with 5 additions and 158 deletions
dashboards/general/service.dashboard.jsonnet
View file @ 271ee97f
......@@ -166,58 +166,6 @@ local apdexPanel() = generalGraphPanel(
legendFormat='last week',
)
)
.addTarget(
promQuery.target('
avg(
clamp_max(
gitlab_service_apdex:ratio:avg_over_time_1w{environment="$environment", type="$type", stage="$stage"} +
$sigma * gitlab_service_apdex:ratio:stddev_over_time_1w{environment="$environment", type="$type", stage="$stage"},
1
)
)
',
legendFormat='upper normal',
),
)
.addTarget(
promQuery.target('
avg(
clamp_min(
gitlab_service_apdex:ratio:avg_over_time_1w{environment="$environment", type="$type", stage="$stage"} -
$sigma * gitlab_service_apdex:ratio:stddev_over_time_1w{environment="$environment", type="$type", stage="$stage"},
0
)
)
',
legendFormat='lower normal',
),
)
.addTarget( // Legacy metric - remove 2020-01-01
promQuery.target('
avg(
clamp_max(
gitlab_service_apdex:ratio:avg_over_time_1w{environment="$environment", type="$type", stage=""} +
$sigma * gitlab_service_apdex:ratio:stddev_over_time_1w{environment="$environment", type="$type", stage=""},
1
)
)
',
legendFormat='upper normal (legacy)',
),
)
.addTarget( // Legacy metric - remove 2020-01-01
promQuery.target('
avg(
clamp_min(
gitlab_service_apdex:ratio:avg_over_time_1w{environment="$environment", type="$type", stage=""} -
$sigma * gitlab_service_apdex:ratio:stddev_over_time_1w{environment="$environment", type="$type", stage=""},
0
)
)
',
legendFormat='lower normal (legacy)',
),
)
.resetYaxes()
.addYaxis(
format='percentunit',
......@@ -277,56 +225,6 @@ local errorRatesPanel() =
legendFormat='last week',
)
)
.addTarget(
promQuery.target('
avg(
(
gitlab_service_errors:ratio:avg_over_time_1w{environment="$environment", type="$type", stage="$stage"} +
$sigma * gitlab_service_errors:ratio:stddev_over_time_1w{environment="$environment", type="$type", stage="$stage"}
)
)
',
legendFormat='upper normal',
),
)
.addTarget(
promQuery.target('
avg(
clamp_min(
gitlab_service_errors:ratio:avg_over_time_1w{environment="$environment", type="$type", stage="$stage"} -
$sigma * gitlab_service_errors:ratio:stddev_over_time_1w{environment="$environment", type="$type", stage="$stage"},
0
)
)
',
legendFormat='lower normal',
),
)
.addTarget( // Legacy metric - remove 2020-01-01
promQuery.target('
avg(
(
gitlab_service_errors:ratio:avg_over_time_1w{environment="$environment", type="$type", stage=""} +
$sigma * gitlab_service_errors:ratio:stddev_over_time_1w{environment="$environment", type="$type", stage=""}
)
)
',
legendFormat='upper normal (legacy)',
),
)
.addTarget( // Legacy metric - remove 2020-01-01
promQuery.target('
avg(
clamp_min(
gitlab_service_errors:ratio:avg_over_time_1w{environment="$environment", type="$type", stage=""} -
$sigma * gitlab_service_errors:ratio:stddev_over_time_1w{environment="$environment", type="$type", stage=""},
0
)
)
',
legendFormat='lower normal (legacy)',
),
)
.resetYaxes()
.addYaxis(
format='percentunit',
......@@ -378,57 +276,6 @@ local serviceAvailabilityPanel() =
legendFormat='last week',
)
)
.addTarget( // Upper sigma bound
promQuery.target('
avg(
clamp_max(
gitlab_service_availability:ratio:avg_over_time_1w{environment="$environment", type="$type", stage="$stage"} +
$sigma * gitlab_service_availability:ratio:stddev_over_time_1w{environment="$environment", type="$type", stage="$stage"},
1)
)
',
legendFormat='upper normal',
),
)
.addTarget( // Lower sigma bound
promQuery.target('
avg(
clamp_min(
gitlab_service_availability:ratio:avg_over_time_1w{environment="$environment", type="$type", stage="$stage"} -
$sigma * gitlab_service_availability:ratio:stddev_over_time_1w{environment="$environment", type="$type", stage="$stage"},
0
)
)
',
legendFormat='lower normal',
),
)
.addTarget( // Legacy metric - remove 2020-01-01
promQuery.target('
avg(
clamp_max(
gitlab_service_availability:ratio:avg_over_time_1w{environment="$environment", type="$type", stage=""} +
$sigma * gitlab_service_availability:ratio:stddev_over_time_1w{environment="$environment", type="$type", stage=""},
1)
)
',
legendFormat='upper normal (legacy)',
),
)
.addTarget( // Legacy metric - remove 2020-01-01
promQuery.target('
avg(
clamp_min(
gitlab_service_availability:ratio:avg_over_time_1w{environment="$environment", type="$type", stage=""} -
$sigma * gitlab_service_availability:ratio:stddev_over_time_1w{environment="$environment", type="$type", stage=""},
0
)
)
',
legendFormat='lower normal (legacy)',
),
)
.resetYaxes()
.addYaxis(
format='percentunit',
......@@ -483,7 +330,7 @@ local qpsPanel() =
.addTarget(
promQuery.target('
gitlab_service_ops:rate:prediction{environment="$environment", type="$type", stage="$stage"} +
($sigma / 2) * gitlab_service_ops:rate:stddev_over_time_1w{environment="$environment", type="$type", stage="$stage"}
$sigma * gitlab_service_ops:rate:stddev_over_time_1w{environment="$environment", type="$type", stage="$stage"}
',
legendFormat='upper normal',
),
......@@ -493,7 +340,7 @@ local qpsPanel() =
avg(
clamp_min(
gitlab_service_ops:rate:prediction{environment="$environment", type="$type", stage="$stage"} -
($sigma / 2) * gitlab_service_ops:rate:stddev_over_time_1w{environment="$environment", type="$type", stage="$stage"},
$sigma * gitlab_service_ops:rate:stddev_over_time_1w{environment="$environment", type="$type", stage="$stage"},
0
)
)
......@@ -504,7 +351,7 @@ local qpsPanel() =
.addTarget( // Legacy metric - remove 2020-01-01
promQuery.target('
gitlab_service_ops:rate:prediction{environment="$environment", type="$type", stage=""} +
($sigma / 2) * gitlab_service_ops:rate:stddev_over_time_1w{environment="$environment", type="$type", stage=""}
$sigma * gitlab_service_ops:rate:stddev_over_time_1w{environment="$environment", type="$type", stage=""}
',
legendFormat='upper normal (legacy)',
),
......@@ -514,7 +361,7 @@ local qpsPanel() =
avg(
clamp_min(
gitlab_service_ops:rate:prediction{environment="$environment", type="$type", stage=""} -
($sigma / 2) * gitlab_service_ops:rate:stddev_over_time_1w{environment="$environment", type="$type", stage=""},
$sigma * gitlab_service_ops:rate:stddev_over_time_1w{environment="$environment", type="$type", stage=""},
0
)
)
......
dashboards/series_overrides.libsonnet
View file @ 271ee97f
......@@ -84,7 +84,7 @@ local colors = import 'colors.libsonnet';
"dashes": true,
"legend": true,
"lines": true,
"linewidth": 2,
"linewidth": 4,
"dashLength": 4,
"spaceLength": 4,
"nullPointMode": "connected",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment