Refactor SLO Alerting in Prepation for GET monitoring
Part of #80 (closed)
Some yakshaving in preparation for GET SLO monitoring.
By cleaning up this code, it's also exposed some issues with the existing code generation:
- No traffic cessation alerts for regional SLIs, eg
ApiServiceGraphqlQueriesTrafficCessationRegional - Regional SLIs alert on Apdex SLO violations, but not Error Rate SLO violations. This fixes that problem. See
ApiServiceLoadbalancerErrorSLOViolationRegionalfor example.
Edited by Andrew Newdigate