Skip to content

Refactor SLO Alerting in Prepation for GET monitoring

Andrew Newdigaterequested to merge
get-slo-alerting into master

Part of #80 (closed)

Some yakshaving in preparation for GET SLO monitoring.

By cleaning up this code, it's also exposed some issues with the existing code generation:

  1. No traffic cessation alerts for regional SLIs, eg ApiServiceGraphqlQueriesTrafficCessationRegional
  2. Regional SLIs alert on Apdex SLO violations, but not Error Rate SLO violations. This fixes that problem. See ApiServiceLoadbalancerErrorSLOViolationRegional for example.
Edited by Andrew Newdigate

Merge request reports