Update localization-request.md to automatically add locale labels.
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA
Hey, as per our Slack thread here with @maudl-ext I wanted to have locale labels automatically added to new localization request issues.
The only way I could think of adding them automatically is having requestors delete the languages they don't need, which is a change in the way we were processing the requests. What do you think of this proposal? @rasamhossain @opysaryuk
Merge request reports
Activity
Thanks for your contribution to GitLab @mjsibanez-ext!
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
- If you need help, comment @gitlab-bot help or come say hi on Discord.
- When you're ready for a review, comment on this merge request with @gitlab-bot ready.
- We welcome AI-generated contributions! Read more/check the box at the top of the merge request description.
- To add labels to your merge request, comment @gitlab-bot label ~"label1" ~"label2".
This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @mjsibanez-ext
assigned to @opysaryuk and unassigned @mjsibanez-ext
requested review from @rasamhossain
Looks great, @mjsibanez-ext !
Please give a quick review @rasamhossain
, and I'll merge, and we can iterate as needed.Review completed. Had a concern about the locale code for spanish (international), but this issue confirms that. Down the road, when we have too many locale codes, we may have to re-think this approach and try to find a way to only tag the correct locale codes (instead of deleting them if not needed), but this approach works perfect for the time being.
@opysaryuk - please feel free to close the MR, if everything checks out on your side too!
Edited by Rasam Hossainmentioned in commit c7fd1cd1
@mjsibanez-ext, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
Hi @mjsibanez-ext, I tested the new process but the label is not showing up in the sidebar (see issue). Is it normal?
uuggh that's not the expected behaviour
I've seen that @opysaryuk has made some requests tests but it didn't work for him either. I've asked Gitlab Duo and it says that's not working because they need to be at the root level of the description, not part of the checklist. I'll try edit that and see if it works
mentioned in issue #234 (closed)