Unicorn logs on git servers are overwhelmed with deprecation warnings
/var/log/gitlab/unicorn/unicorn_stderr.log
contains a lot of these:
DEPRECATION WARNING: legacy_disk_path is deprecated and will be removed from GitLab 11.0. (called from block in strip_storage_path at /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/repo_path.rb:24)
DEPRECATION WARNING: legacy_disk_path is deprecated and will be removed from GitLab 11.0. (called from block in strip_storage_path at /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/repo_path.rb:24)
DEPRECATION WARNING: legacy_disk_path is deprecated and will be removed from GitLab 11.0. (called from block in strip_storage_path at /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/repo_path.rb:24)
DEPRECATION WARNING: legacy_disk_path is deprecated and will be removed from GitLab 11.0. (called from block in strip_storage_path at /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/repo_path.rb:24)
DEPRECATION WARNING: legacy_disk_path is deprecated and will be removed from GitLab 11.0. (called from block in strip_storage_path at /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/repo_path.rb:24)
DEPRECATION WARNING: legacy_disk_path is deprecated and will be removed from GitLab 11.0. (called from block in strip_storage_path at /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/repo_path.rb:24)
DEPRECATION WARNING: legacy_disk_path is deprecated and will be removed from GitLab 11.0. (called from block in strip_storage_path at /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/repo_path.rb:24)
DEPRECATION WARNING: legacy_disk_path is deprecated and will be removed from GitLab 11.0. (called from path_to_repo at /opt/gitlab/embedded/service/gitlab-rails/app/models/repository.rb:99)
Its overflowing git nodes log partitions at about 5-10MB per minute on every box. I truncated those log files on all the git nodes, I'm looking if this also impacts other nodes.
This issue is to track the resolution. We have about 10G of free space on git nodes, so we'll run out of space every day if we don't disable those messages.