Suggestion: ignore type::maintenance
Ignoring typemaintenance would appear to reduce false positives.
It would have muted 8 of the 26 alerts we've had this year (a 30% improvement in efficiency).
Based only on this year's alerts, it also would not have caused any false negatives (i.e. we'd still get all the correct alerts). But that's the risk - by choosing to ignore a set of issues we might miss a public MR that shouldn't be.
Examples of typemaintenance maintenancedependency issues that were alerted on but green ticked with no action:
- go.mod: Upgrade the cloudflare/circl library to... (gitlab-org/gitaly!6669 - merged)
- Update docker+machine version to v0.16.2-gitlab.24 (gitlab-org/gitlab-runner!4609 - merged)
- Update redis/redis from 7.0.14 to 7.0.15 (gitlab-org/omnibus-gitlab!7348 - merged)
If we broadened it to any typemaintenance we'd also get the following, which seemed to get a green tick with no action:
- Update Omnibus PostgreSQL versions (gitlab-org/gitlab!144171 - merged)
- Clarify using full 40-character sha for `includ... (gitlab-org/gitlab!141024 - merged)
- Changing Develop to Extend (gitlab-org/gitlab!142217 - merged)
- Changing Develop to Extend (gitlab-org/gitlab!142217 - merged)
-
🤷 Draft: Enable security related jobs in CI (gitlab-org/omnibus-gitlab!4767 - closed)
But we'd always still alert on ones that lack the maintenance label (but probably should have had it / are still false positives), e.g.:
- protoc-gen-doc: Update github.com/gogo/protobuf (gitlab-org/gitaly!6600 - merged)
- tools/protolint: update package to latest (gitlab-org/gitaly!6632 - merged)
- protolint: Update golang.org/x/text (gitlab-org/gitaly!6595 - merged)
Proposal
Ignore all MRs with typemaintenance labels.