Review duplication in fields logged from Rails
A few fields are logging duplicate information in the logs now that we log context information (brought up by Sean in https://gitlab.com/gitlab-org/labkit-ruby/-/merge_requests/49#note_478172611)
-
json.remote_ip->json.meta.remote_ip -
json.username(andjson.user_id) ->json.meta.user(I think we should also log theuser_idinsidemeta). -
json.controller(andjson.action) ->json.meta.caller_id
The context can be propagated across services, and the fields need to be defined in labkit, ensuring consistent naming across those services for logging. Which is why I think we should remove the fields outside of the meta namespace. But some of the fields might be used in other tooling.