Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
scalability
scalability
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 132
    • Issues 132
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 2
    • Merge Requests 2
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.com
  • GitLab Infrastructure Team
  • scalabilityscalability
  • Issues
  • #337

Closed
Open
Opened Apr 29, 2020 by Sean McGivern@smcgivernMaintainer

Remove Sidekiq Cluster option from Helm charts

In 12.10, via #198 (closed), we added support for Sidekiq Cluster in our Helm charts.

In 13.0, via gitlab-org/charts/gitlab#1989 (closed), we are making it the default, but still allowing people to disable cluster if they want. For the Helm charts, the main difference is in how queues and negateQueues are configured, as described in that issue.

In 14.0, we'll remove the cluster option:

  1. We'll always use sidekiq-cluster in https://gitlab.com/gitlab-org/build/CNG/-/blob/master/gitlab-sidekiq/scripts/process-wrapper.
  2. We'll only support strings for queues and negateQueues.
  3. We can remove https://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/charts/gitlab/charts/sidekiq/templates/configmap-queue.yaml and the associated code entirely.
  4. We'll need to add deprecations: https://docs.gitlab.com/charts/architecture/decisions.html#breaking-changes-via-deprecation
Edited Apr 30, 2020 by Sean McGivern
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gitlab-com/gl-infra/scalability#337