Doorkeeper endpoints are missing application context and attribution
We override some controllers for Doorkeeper::OpenidConnect
. But I noticed in the logs that none of these requests include metadata: https://log.gprd.gitlab.net/goto/62157bf0-6e10-11ec-bf16-136dbae1ae92
This happened because these controllers do not inherit ApplicationController
but rather Doorkeeper::ApplicationController
.
These did passed our every_controller_spec
because these controllers do not include Gitlab::EndpointAttributes
.
I think we should customize the Doorkeeper
application controller with our own Gitlab::Doorkeeper::ApplicationController
or the regular ApplicationController
if possible and use that to provide context and attributes to the controllers.